Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: update instructions for create-strapi-app #35288

Merged
merged 2 commits into from Mar 13, 2022
Merged

examples: update instructions for create-strapi-app #35288

merged 2 commits into from Mar 13, 2022
+2 −2

Conversation

bernard-lin
Copy link
Contributor

@bernard-lin bernard-lin commented Mar 13, 2022 •
edited

Not sure how you want to handle this, but the current instructions aren't compatible with the latest version of strapi and migration steps aren't super clear yet. It does work flawlessly with v3 of Strapi though.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • [X ] Make sure the linting passes by running yarn lint

@bernard-lin
Update README.md
5c2640c 
Not sure how you want to handle this, but the current instructions aren't compatible with the latest version of strapi and migration steps aren't super clear yet. It does work flawlessly with v3 of Strapi though.
@ijjk ijjk added the examples Issue/PR related to examples label Mar 13, 2022
@leerob leerob changed the title Update README.md examples: update instructions for create-strapi-app Mar 13, 2022
@kodiakhq kodiakhq bot merged commit 9f54b56 into vercel:canary Mar 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bernard-lin @leerob @ijjk