Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info on context.ctx argument in _app docs page #35303

Merged
merged 1 commit into from Mar 15, 2022
Merged

Add info on context.ctx argument in _app docs page #35303

merged 1 commit into from Mar 15, 2022
+2 −0

Conversation

amandeepmittal
Copy link
Contributor

This PR adds the reference of context object to use ctx used in the getInitialProps for _app.
More context in the suggestion here.

Bug

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@amandeepmittal amandeepmittal changed the title Add info on context.ctx argument Add info on context.ctx argument in _app docs page Mar 14, 2022
@balazsorban44 balazsorban44 merged commit 7891645 into vercel:canary Mar 15, 2022
@amandeepmittal amandeepmittal deleted the add-appContext-info branch March 16, 2022 05:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

appContext.router.pathname using old value after using router.push for customized app
3 participants
@amandeepmittal @balazsorban44 @ijjk