Send build trace to datadog in CI #35306

Brooooooklyn · 2022-03-14T14:26:25Z

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

ijjk · 2022-03-23T12:08:37Z

Failing test suites

Commit: 9ff819b

yarn testheadless test/integration/react-streaming-and-server-components/test/index.test.js

Edge runtime - dev > should be able to navigate between rsc pages
Node.js runtime dev > should be able to navigate between rsc pages

Expand output

● Edge runtime - dev › should be able to navigate between rsc pages

expect(received).toBe(expected) // Object.is equality

Expected: "http://localhost:43141/streaming-rsc"
Received: "http://localhost:43141/"

  113 |     await browser.waitForElementByCss('#goto-streaming-rsc').click()
  114 |     await new Promise((res) => setTimeout(res, 1500))
> 115 |     expect(await browser.url()).toBe(
      |                                 ^
  116 |       `http://localhost:${context.appPort}/streaming-rsc`
  117 |     )
  118 |

  at Object.<anonymous> (integration/react-streaming-and-server-components/test/rsc.js:115:33)

● Node.js runtime dev › should be able to navigate between rsc pages

expect(received).toBe(expected) // Object.is equality

Expected: "http://localhost:46671/streaming-rsc"
Received: "http://localhost:46671/"

  113 |     await browser.waitForElementByCss('#goto-streaming-rsc').click()
  114 |     await new Promise((res) => setTimeout(res, 1500))
> 115 |     expect(await browser.url()).toBe(
      |                                 ^
  116 |       `http://localhost:${context.appPort}/streaming-rsc`
  117 |     )
  118 |

  at Object.<anonymous> (integration/react-streaming-and-server-components/test/rsc.js:115:33)

Read more about building and testing Next.js in contributing.md.

styfle

Looks good to me!

Might want @kwonoj review this too

Brooooooklyn · 2022-03-23T14:38:44Z

@kwonoj should we send some data via these scripts to test if anything works fine before merging it?

bench/nested-deps/bench.mjs

ijjk · 2022-03-29T06:36:00Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js trace-ci	Change
buildDuration	15s	15.1s	⚠️ +120ms
buildDurationCached	5.9s	5.7s	-165ms
nodeModulesSize	467 MB	467 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js trace-ci	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.112	3.112	✓
/ avg req/sec	803.25	803.44	+0.19
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.352	1.346	-0.01
/error-in-render avg req/sec	1848.44	1857.49	+9.05

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js trace-ci	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28.4 kB	28.4 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.1 kB	72.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js trace-ci	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js trace-ci	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	192 B	192 B	✓
amp-HASH.js gzip	309 B	309 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.57 kB	2.57 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.48 kB	5.48 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.26 kB	2.26 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.2 kB	15.2 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js trace-ci	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js trace-ci	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Decrease detected ✓)

General

	vercel/next.js canary	vercel/next.js trace-ci	Change
buildDuration	18.3s	17.9s	-409ms
buildDurationCached	5.7s	5.9s	⚠️ +164ms
nodeModulesSize	467 MB	467 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js trace-ci	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.067	3.024	-0.04
/ avg req/sec	815.15	826.62	+11.47
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.35	1.37	⚠️ +0.02
/error-in-render avg req/sec	1852.53	1824.28	⚠️ -28.25

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js trace-ci	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.8 kB	28.8 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.7 kB	72.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js trace-ci	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js trace-ci	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	313 B	313 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	2.56 kB	2.56 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	921 B	921 B	✓
image-HASH.js gzip	5.59 kB	5.59 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.33 kB	2.33 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	388 B	388 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.3 kB	15.3 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js trace-ci	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js trace-ci	Change
index.html gzip	532 B	532 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 3b25061

This comment has been minimized.

Sign in to view

Brooooooklyn force-pushed the trace-ci branch from c0ebf41 to 08fbea5 Compare March 17, 2022 06:16

This comment has been minimized.

Sign in to view

Brooooooklyn marked this pull request as ready for review March 23, 2022 10:23

Brooooooklyn requested review from timneutkens, ijjk, shuding, styfle, huozhi and padmaia as code owners March 23, 2022 10:23

Brooooooklyn force-pushed the trace-ci branch from 08fbea5 to abd2139 Compare March 23, 2022 10:45

This comment has been minimized.

Sign in to view

Brooooooklyn force-pushed the trace-ci branch 2 times, most recently from ee5e689 to 9ff819b Compare March 23, 2022 11:30

This comment has been minimized.

Sign in to view

styfle previously approved these changes Mar 23, 2022

View reviewed changes

Send build trace to datadog in CI

cd82257

Brooooooklyn dismissed styfle’s stale review via 4adebe2 March 29, 2022 05:28

Brooooooklyn force-pushed the trace-ci branch from 9ff819b to 4adebe2 Compare March 29, 2022 05:28

kwonoj reviewed Mar 29, 2022

View reviewed changes

bench/nested-deps/bench.mjs Outdated Show resolved Hide resolved

kwonoj reviewed Mar 29, 2022

View reviewed changes

bench/nested-deps/bench.mjs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

kwonoj previously approved these changes Mar 29, 2022

View reviewed changes

Build release type binary on PRs

3b25061

Brooooooklyn dismissed kwonoj’s stale review via 3b25061 March 29, 2022 06:18

Brooooooklyn force-pushed the trace-ci branch from 4adebe2 to 3b25061 Compare March 29, 2022 06:18

kwonoj approved these changes Mar 29, 2022

View reviewed changes

timneutkens approved these changes Mar 31, 2022

View reviewed changes

Merge branch 'canary' into trace-ci

5aee695

timneutkens merged commit 6577b2e into canary Mar 31, 2022

timneutkens deleted the trace-ci branch March 31, 2022 12:38

kwonoj mentioned this pull request Mar 31, 2022

ci(workflow): fix api key for trace #35804

Merged

10 tasks

github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Send build trace to datadog in CI #35306

Send build trace to datadog in CI #35306

Brooooooklyn commented Mar 14, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Mar 23, 2022

styfle left a comment

Brooooooklyn commented Mar 23, 2022

This comment has been minimized.

ijjk commented Mar 29, 2022

Send build trace to datadog in CI #35306

Send build trace to datadog in CI #35306

Conversation

Brooooooklyn commented Mar 14, 2022

Bug

Feature

Documentation / Examples

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Mar 23, 2022

Failing test suites

styfle left a comment

Choose a reason for hiding this comment

Brooooooklyn commented Mar 23, 2022

This comment has been minimized.

ijjk commented Mar 29, 2022

Stats from current PR