Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added note about why Next.js used 307 and 308 status codes #35325

Merged
merged 3 commits into from Mar 19, 2022
Merged

Added note about why Next.js used 307 and 308 status codes #35325

merged 3 commits into from Mar 19, 2022

Conversation

molebox
Copy link
Contributor

@molebox molebox commented Mar 15, 2022 •
edited

This PR looks to clear up some confusion users are having around our decision to use 307 and 308 redirects, instead of 301 and 302

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk @styfle
Apply suggestions from code review
8901cba 
Co-authored-by: Steven <steven@ceriously.com>
@kodiakhq kodiakhq bot merged commit 6f24c20 into vercel:canary Mar 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle left review comments

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
created-by: Next.js docs team PRs by the Next.js docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@molebox @styfle @ijjk