Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop browser field for edge runtime #35335

Merged
merged 5 commits into from Mar 16, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 15, 2022

Related to #31678

For streaming pages,

Nodejs runtime: setting global runtime to "nodejs" will work with default module resolution.
Edge runtime: previously next.js will pick up browser field since it's the "similar" asset (unlike nodejs) to edge runtime but browser specific things like DOM api could breaks cause edge runtime is more like worker without dom runtime.

This PR is to revert the main field resolution behavior. And if you have a library targeting multiple runtime with different fields, ideally is to make it more isomorphic and will be easy to use in edge runtime

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that node_modules was unexpectedly committed, or intended (as a mock)?

@huozhi
Copy link
Member Author

huozhi commented Mar 15, 2022

@shuding it's intended for new test case: a lib with both module field and browser field and we pick the module field export

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Mar 15, 2022
@huozhi huozhi requested a review from shuding March 15, 2022 15:57
@ijjk

This comment has been minimized.

shuding
shuding previously approved these changes Mar 16, 2022
@ijjk
Copy link
Member

ijjk commented Mar 16, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
buildDuration 16.2s 16.1s -78ms
buildDurationCached 6.3s 6.2s -51ms
nodeModulesSize 456 MB 456 MB ⚠️ +110 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
/ failed reqs 0 0
/ total time (seconds) 3.235 3.232 0
/ avg req/sec 772.77 773.4 +0.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.394 1.43 ⚠️ +0.04
/error-in-render avg req/sec 1793.8 1748.62 ⚠️ -45.18
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
buildDuration 19.4s 19.1s -315ms
buildDurationCached 6.4s 6.4s ⚠️ +66ms
nodeModulesSize 456 MB 456 MB ⚠️ +110 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
/ failed reqs 0 0
/ total time (seconds) 3.143 3.155 ⚠️ +0.01
/ avg req/sec 795.36 792.44 ⚠️ -2.92
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.389 1.383 -0.01
/error-in-render avg req/sec 1799.89 1807.08 +7.19
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js edge/drop-browser-field Change
index.html gzip 530 B 530 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: d0406bc

@kodiakhq kodiakhq bot merged commit efdb87d into vercel:canary Mar 16, 2022
@huozhi huozhi deleted the edge/drop-browser-field branch March 16, 2022 15:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants