Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep fouc tags for streaming #35417

Merged
merged 2 commits into from Mar 18, 2022
Merged

Keep fouc tags for streaming #35417

merged 2 commits into from Mar 18, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 17, 2022

Basically the revert change of #31187

The fouc tag are rendered in first place, and the removing fouc tags script is executed before hydration which is early enough. This will unblock the dev mode of global CSS development

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 18, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
buildDuration 18.3s 17.9s -379ms
buildDurationCached 7.2s 7.2s ⚠️ +87ms
nodeModulesSize 456 MB 456 MB -182 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
/ failed reqs 0 0
/ total time (seconds) 3.692 3.643 -0.05
/ avg req/sec 677.21 686.22 +9.01
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.572 1.571 0
/error-in-render avg req/sec 1590.2 1591.28 +1.08
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
buildDuration 21.6s 21.7s ⚠️ +100ms
buildDurationCached 7.2s 7.1s -75ms
nodeModulesSize 456 MB 456 MB -182 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
/ failed reqs 0 0
/ total time (seconds) 3.648 3.681 ⚠️ +0.03
/ avg req/sec 685.33 679.23 ⚠️ -6.1
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.547 1.603 ⚠️ +0.06
/error-in-render avg req/sec 1615.96 1559.98 ⚠️ -55.98
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix-styling-fouc Change
index.html gzip 531 B 531 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: b9b685e

@kodiakhq kodiakhq bot merged commit 279f47b into vercel:canary Mar 18, 2022
@shuding shuding deleted the fix-styling-fouc branch March 18, 2022 01:20
@huozhi huozhi restored the fix-styling-fouc branch March 18, 2022 12:46
@huozhi huozhi deleted the fix-styling-fouc branch March 18, 2022 12:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants