Clean up legacy react 18 tests

[huozhi]

source changes

• Error dynamic suspense option in non concurrent mode, don't check react root anymore since they should be bound

tests changes

• Remove duplicated rsc client test
• Merge type checking cases (next/dynamic)
• Remove blocking rendering tests cases since we should opt-in Fizz rendering when using React.lazy
• Remove some thrown promises cases, leverage the streaming component we had in RSC test

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
buildDuration	15.3s	15.3s	-36ms
buildDurationCached	6s	6s	⚠️ +1ms
nodeModulesSize	467 MB	467 MB	-234 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.952	2.921	-0.03
/ avg req/sec	846.82	855.86	+9.04
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.179	1.181	0
/error-in-render avg req/sec	2120.76	2117.22	⚠️ -3.54

Client Bundles (main, webpack)

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28 kB	28 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.6 kB	71.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	192 B	192 B	✓
amp-HASH.js gzip	309 B	309 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.57 kB	2.57 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.48 kB	5.48 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.26 kB	2.26 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.2 kB	15.2 kB	✓

Client Build Manifests

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Diffs

Diff for _buildManifest.js

@@ -8,7 +8,7 @@ self.__BUILD_MANIFEST = {
     "static\u002Fchunks\u002Fpages\u002Fcss-16a755ee71604f2b.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-a917cf735c6c2990.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-84f8d81080673359.js"
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-96a5d6ed07cf5a83.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-9dfe734f583d4926.js"],

Diff for dynamic-HASH.js

@@ -106,14 +106,11 @@
         // Support for passing options, eg: dynamic(import('../hello-world'), {loading: () => <p>Loading something</p>})
         loadableOptions = _objectSpread({}, loadableOptions, options);
         var suspenseOptions = loadableOptions;
-        if (true) {
-          // Error if react root is not enabled and `suspense` option is set to true
-          if (true && suspenseOptions.suspense) {
-            // TODO: add error doc when this feature is stable
-            throw new Error(
-              "Invalid suspense option usage in next/dynamic. Read more: https://nextjs.org/docs/messages/invalid-dynamic-suspense"
-            );
-          }
+        // Error if Fizz rendering is not enabled and `suspense` option is set to true
+        if (true && suspenseOptions.suspense) {
+          throw new Error(
+            "Invalid suspense option usage in next/dynamic. Read more: https://nextjs.org/docs/messages/invalid-dynamic-suspense"
+          );
         }
         if (suspenseOptions.suspense) {
           return loadableFn(suspenseOptions);

---

Default Build with SWC (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
buildDuration	18.7s	18.6s	-101ms
buildDurationCached	6s	6s	-43ms
nodeModulesSize	467 MB	467 MB	-234 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.927	2.933	⚠️ +0.01
/ avg req/sec	854.14	852.48	⚠️ -1.66
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.165	1.176	⚠️ +0.01
/error-in-render avg req/sec	2145.24	2126.14	⚠️ -19.1

Client Bundles (main, webpack)

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.2 kB	28.2 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.1 kB	72.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	313 B	313 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	2.56 kB	2.56 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	921 B	921 B	✓
image-HASH.js gzip	5.59 kB	5.59 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.33 kB	2.33 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	388 B	388 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.3 kB	15.3 kB	✓

Client Build Manifests

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	huozhi/next.js clean-up-react-18-tests	Change
index.html gzip	532 B	532 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Diffs

Diff for _buildManifest.js

@@ -8,7 +8,7 @@ self.__BUILD_MANIFEST = {
     "static\u002Fchunks\u002Fpages\u002Fcss-16a755ee71604f2b.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-a917cf735c6c2990.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-84f8d81080673359.js"
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-96a5d6ed07cf5a83.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-9dfe734f583d4926.js"],

Diff for dynamic-HASH.js

@@ -106,14 +106,11 @@
         // Support for passing options, eg: dynamic(import('../hello-world'), {loading: () => <p>Loading something</p>})
         loadableOptions = _objectSpread({}, loadableOptions, options);
         var suspenseOptions = loadableOptions;
-        if (true) {
-          // Error if react root is not enabled and `suspense` option is set to true
-          if (true && suspenseOptions.suspense) {
-            // TODO: add error doc when this feature is stable
-            throw new Error(
-              "Invalid suspense option usage in next/dynamic. Read more: https://nextjs.org/docs/messages/invalid-dynamic-suspense"
-            );
-          }
+        // Error if Fizz rendering is not enabled and `suspense` option is set to true
+        if (true && suspenseOptions.suspense) {
+          throw new Error(
+            "Invalid suspense option usage in next/dynamic. Read more: https://nextjs.org/docs/messages/invalid-dynamic-suspense"
+          );
         }
         if (suspenseOptions.suspense) {
           return loadableFn(suspenseOptions);

Commit: 76b3ddf