Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: workarounds for router not resetting state (fixes #35138) #35651

Merged
merged 5 commits into from Apr 16, 2022
Merged

Docs: workarounds for router not resetting state (fixes #35138) #35651

merged 5 commits into from Apr 16, 2022

Conversation

jameshfisher
Copy link
Contributor

@jameshfisher jameshfisher commented Mar 28, 2022 •
edited by balazsorban44

Documentation / Examples

  • Make sure the linting passes by running yarn lint

fixes #35138

@balazsorban44
Copy link
Member

Could you make sure linting passes?

@ijjk ijjk merged commit a2e65ac into vercel:canary Apr 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 left review comments

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: "manually ensure the state is updated using useEffect" is vague and hidden
3 participants
@jameshfisher @balazsorban44 @ijjk