Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(with-mongodb): Change comment of MongoDB client in getServerSideProps #35750

Merged
merged 5 commits into from Mar 31, 2022

Conversation

SokichiFujita
Copy link
Contributor

@SokichiFujita SokichiFujita commented Mar 30, 2022

Previously const client had been defined around the comment. Developer could easily see and understand what is the client. When try - catch was added, client also removed because of avoiding unused constant.

So currently developer may not be able to naturally understand what is the client.

Then I fix the comment to make the client clear.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Mar 30, 2022
@SokichiFujita SokichiFujita changed the title Change comment of client in getServerSideProps fix(with-mongodb): Change comment of client in getServerSideProps Mar 30, 2022
@SokichiFujita SokichiFujita changed the title fix(with-mongodb): Change comment of client in getServerSideProps fix(with-mongodb): Change comment of MongoDB client in getServerSideProps Mar 30, 2022
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk ijjk merged commit 7f798c3 into vercel:canary Mar 31, 2022
@kwonoj kwonoj mentioned this pull request Mar 31, 2022
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants