Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for basic dynamic import with react 18 hydration #35772

Merged
merged 1 commit into from Mar 31, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 31, 2022

x-ref: #35728

The hydration mismatch is fixed by #35732, that document could collect the dyamic imports module ids before the shell is flushed. Add a test for it

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Mar 31, 2022
@ijjk
Copy link
Member

ijjk commented Mar 31, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
buildDuration 15.4s 15.3s -52ms
buildDurationCached 6s 6s ⚠️ +8ms
nodeModulesSize 477 MB 477 MB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
/ failed reqs 0 0
/ total time (seconds) 2.963 2.947 -0.02
/ avg req/sec 843.6 848.2 +4.6
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.22 1.208 -0.01
/error-in-render avg req/sec 2048.65 2069.05 +20.4
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.7 kB 15.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
buildDuration 18s 17.9s -53ms
buildDurationCached 6s 6.1s ⚠️ +64ms
nodeModulesSize 477 MB 477 MB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
/ failed reqs 0 0
/ total time (seconds) 2.964 2.979 ⚠️ +0.02
/ avg req/sec 843.33 839.24 ⚠️ -4.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.224 1.2 -0.02
/error-in-render avg req/sec 2043.01 2083.51 +40.5
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.8 kB 15.8 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/legacy-dynamic-react-18 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 7356666

@kodiakhq kodiakhq bot merged commit 612cc88 into vercel:canary Mar 31, 2022
@huozhi huozhi deleted the test/legacy-dynamic-react-18 branch March 31, 2022 10:04
@kwonoj kwonoj mentioned this pull request Mar 31, 2022
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants