Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(trace): adjust agent env variables #35790

Merged
merged 4 commits into from Mar 31, 2022
Merged

ci(trace): adjust agent env variables #35790

merged 4 commits into from Mar 31, 2022

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Mar 31, 2022

This PR adjusts few env variables to send trace correctly. Still have to verify it if it sent correctly though.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

styfle
styfle previously approved these changes Mar 31, 2022
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we skip this job when secrets.DATA_DOG_API_KEY isn't available e.g. on PRs? Seems it is currently failing on forks due to this missing

@kwonoj
Copy link
Contributor Author

kwonoj commented Mar 31, 2022

Should we skip this job when secrets.DATA_DOG_API_KEY

I think so too. I'll try to amend PR.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@kwonoj kwonoj force-pushed the trace-dd-env branch 3 times, most recently from 781d3cb to b3b7f22 Compare March 31, 2022 19:13
@kwonoj
Copy link
Contributor Author

kwonoj commented Mar 31, 2022

Ok, it took bit long unexpectedly to struggle with gh yaml syntax, but looks like now trace job is skipped properly. Need double check once PR goes in and actual branch works fine though.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 31, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary kwonoj/next.js trace-dd-env Change
buildDuration 13.7s 13.8s ⚠️ +130ms
buildDurationCached 5.4s 5.8s ⚠️ +443ms
nodeModulesSize 477 MB 477 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kwonoj/next.js trace-dd-env Change
/ failed reqs 0 0
/ total time (seconds) 2.8 2.825 ⚠️ +0.03
/ avg req/sec 892.8 885.09 ⚠️ -7.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.277 1.265 -0.01
/error-in-render avg req/sec 1957.82 1976.85 +19.03
Client Bundles (main, webpack)
vercel/next.js canary kwonoj/next.js trace-dd-env Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kwonoj/next.js trace-dd-env Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kwonoj/next.js trace-dd-env Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.7 kB 15.7 kB
Client Build Manifests
vercel/next.js canary kwonoj/next.js trace-dd-env Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kwonoj/next.js trace-dd-env Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary kwonoj/next.js trace-dd-env Change
buildDuration 15.8s 16.1s ⚠️ +293ms
buildDurationCached 5.4s 5.7s ⚠️ +282ms
nodeModulesSize 477 MB 477 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kwonoj/next.js trace-dd-env Change
/ failed reqs 0 0
/ total time (seconds) 2.8 2.789 -0.01
/ avg req/sec 892.83 896.4 +3.57
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.26 1.232 -0.03
/error-in-render avg req/sec 1983.52 2028.72 +45.2
Client Bundles (main, webpack)
vercel/next.js canary kwonoj/next.js trace-dd-env Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kwonoj/next.js trace-dd-env Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kwonoj/next.js trace-dd-env Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.8 kB 15.8 kB
Client Build Manifests
vercel/next.js canary kwonoj/next.js trace-dd-env Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kwonoj/next.js trace-dd-env Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 9a0b9f8

@ijjk ijjk merged commit 69a166b into vercel:canary Mar 31, 2022
@kwonoj kwonoj mentioned this pull request Mar 31, 2022
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
@kwonoj kwonoj deleted the trace-dd-env branch May 9, 2022 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants