Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es-check as CI step in Next pipeline #35913

Closed
merrywhether opened this issue Apr 5, 2022 · 0 comments
Closed

Add es-check as CI step in Next pipeline #35913

merrywhether opened this issue Apr 5, 2022 · 0 comments

Comments

@merrywhether
Copy link

merrywhether commented Apr 5, 2022

Describe the feature you'd like to request

Next currently officially supports ES5 builds for client code: #33227

There have been a few recent bugs related to shipping non-ES5 code in releases:

As a consumer of Next since v5, it seems like the frequency of these regressions has been increasing recently, which is understandable as modern JS moves further and further from ES5. Next should have a CI step that prevents the introduction of these regressions as long as ES5 is the official target. This would prevent consumers from getting blocked on upgrades and having to report these bugs and then waiting for the next release (which can be understandably slow).

Describe the solution you'd like

es-check is a lightweight fast utility that is capable of preventing these types of regressions. Next should introduce its usage as a CI step. The easiest path forward would be running it against the built static output in pre-existing steps (like the e2e or production test suites maybe?). Maybe use the existing open #35912 ticket as a way to test efficacy, since its codepath (next/dynamic) isn't necessarily invoked in many setups.

Describe alternatives you've considered

es-check is the defacto tool in this situation, as evidenced by all of the bug reports mentioning it. It's possible that this could be caught in some sort of browser grid testing, but that would be much slower and might not address all browsers Next consumers are targeting while relying on ES5.

@vercel vercel locked and limited conversation to collaborators Apr 5, 2022
@balazsorban44 balazsorban44 converted this issue into discussion #35923 Apr 5, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant