Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify when you use getServerSideProps #35922

Merged
merged 3 commits into from Apr 7, 2022

Conversation

reconbot
Copy link
Contributor

@reconbot reconbot commented Apr 5, 2022

Removed the misleading TTFB information. It was easy to read that incorrectly and while getStaticProps does have a better TTFB that's not why you might need to avoid getServerSideProps, I gave better examples.

I also wanted to answer "well how do I cache getServerSideProps?" and now there's a link.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Removed the misleading TTFB information. It was easy to read that incorrectly and while getStaticProps does have a better TTFB that's not why you might need to avoid getServerSideProps
@reconbot reconbot requested a review from styfle April 7, 2022 21:55
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 5feb400 into canary Apr 7, 2022
@kodiakhq kodiakhq bot deleted the reconbot/getServerSideProps branch April 7, 2022 22:00
colinhacks pushed a commit to colinhacks/next.js that referenced this pull request Apr 14, 2022
Removed the misleading TTFB information. It was easy to read that incorrectly and while getStaticProps does have a better TTFB that's not why you might need to avoid getServerSideProps, I gave better examples. 

I also wanted to answer "well how do I cache `getServerSideProps`?" and now there's a link.

## Documentation / Examples

- [x] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants