Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to contributing about docs manifest #36020

Merged
merged 2 commits into from Apr 11, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 8, 2022

This aims to document how our docs manifest works to make it easier when updating/moving docs.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

x-ref: #36009

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Apr 8, 2022
@ijjk ijjk marked this pull request as ready for review April 8, 2022 19:29
@ijjk ijjk requested a review from timeyoutakeit April 8, 2022 19:29
@ijjk ijjk mentioned this pull request Apr 8, 2022
10 tasks
@ijjk

This comment has been minimized.

timeyoutakeit
timeyoutakeit previously approved these changes Apr 10, 2022
contributing.md Outdated Show resolved Hide resolved
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@ijjk
Copy link
Member Author

ijjk commented Apr 11, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
buildDuration 15.8s 16s ⚠️ +161ms
buildDurationCached 6.4s 6.1s -228ms
nodeModulesSize 478 MB 478 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
/ failed reqs 0 0
/ total time (seconds) 3.223 3.24 ⚠️ +0.02
/ avg req/sec 775.76 771.72 ⚠️ -4.04
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.38 1.371 -0.01
/error-in-render avg req/sec 1811.19 1822.91 +11.72
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.68 kB 5.68 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.32 kB 2.32 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
buildDuration 18.9s 18.7s -221ms
buildDurationCached 6.2s 6.4s ⚠️ +206ms
nodeModulesSize 478 MB 478 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
/ failed reqs 0 0
/ total time (seconds) 3.271 3.232 -0.04
/ avg req/sec 764.21 773.47 +9.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.416 1.394 -0.02
/error-in-render avg req/sec 1766.1 1793.47 +27.37
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.38 kB 2.38 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js docs/docs-rename-note Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: a7ea58d

@balazsorban44 balazsorban44 merged commit f6de29f into vercel:canary Apr 11, 2022
@ijjk ijjk deleted the docs/docs-rename-note branch April 11, 2022 12:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants