New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Update styled-components with Babel - add types #36125
[examples] Update styled-components with Babel - add types #36125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you are missing a few dev dependencies (typescript
, @types/react
, @types/node
) and tsconfig.json
.
Could you run this example locally first to verify it works? 👍
Sorry, i forgot to add ts config files and dependencies, i have TS installed globally 😅. Here's a modified example showing it works! (The original example continues "My page" 😂) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There's was a fail in CI lint check, because when i generated the tsconfig i didn't code formatted with prettier. I fix it in the last commit. |
This PR is looking forward to improve documentation examples about usage of Next.js with Typescript and Styled-components.
I added Typescript types to the original example Example app with styled-components using babel
Feature
Documentation / Examples
yarn lint
fixes #36008