Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Update styled-components with Babel - add types #36125

Merged
merged 7 commits into from Apr 27, 2022

Conversation

rafae2k
Copy link
Contributor

@rafae2k rafae2k commented Apr 13, 2022

This PR is looking forward to improve documentation examples about usage of Next.js with Typescript and Styled-components.

I added Typescript types to the original example Example app with styled-components using babel

Feature

  • Related issues linked using
  • Documentation added

Documentation / Examples

  • Make sure the linting passes by running yarn lint

fixes #36008

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you are missing a few dev dependencies (typescript, @types/react, @types/node) and tsconfig.json.

Could you run this example locally first to verify it works? 👍

@rafae2k
Copy link
Contributor Author

rafae2k commented Apr 14, 2022

It looks like you are missing a few dev dependencies (typescript, @types/react, @types/node) and tsconfig.json.

Could you run this example locally first to verify it works? 👍

Sorry, i forgot to add ts config files and dependencies, i have TS installed globally 😅.

Here's a modified example showing it works! (The original example continues "My page" 😂)

Screen Shot 2022-04-14 at 10 25 27

balazsorban44
balazsorban44 previously approved these changes Apr 25, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rafae2k
Copy link
Contributor Author

rafae2k commented Apr 27, 2022

Thanks!

There's was a fail in CI lint check, because when i generated the tsconfig i didn't code formatted with prettier.

I fix it in the last commit.

@kodiakhq kodiakhq bot merged commit 0cb2037 into vercel:canary Apr 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom _document file example for styled-components throws a TS bug after updating @types/react to ^18.0.0
3 participants