Fixes scripts in Electron examples. #36133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few issues with the scripts in the Electron examples:
dist
andpack-app
would fail without aname
andversion
inpackage.json
.type-check
didn't work because there isn't atsconfig.json
at the root. It needs to look in theelectron-src
andrenderer
folders respectively.electron-builder
also needed to be updated in order to run on macOS 12.3+ (see electron-userland/electron-builder#6606).Documentation / Examples
yarn lint