Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes scripts in Electron examples. #36133

Merged
merged 6 commits into from Apr 14, 2022

Conversation

manovotny
Copy link
Contributor

There were a few issues with the scripts in the Electron examples:

  • dist and pack-app would fail without a name and version in package.json.
  • type-check didn't work because there isn't a tsconfig.json at the root. It needs to look in the electron-src and renderer folders respectively.

electron-builder also needed to be updated in order to run on macOS 12.3+ (see electron-userland/electron-builder#6606).

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Apr 13, 2022
@manovotny
Copy link
Contributor Author

Interesting... ./scripts/check-examples.sh doesn't want name and version in package.json's.

I can remove them here or look to alter the script depending on what you would like to do here.

@leerob
Copy link
Member

leerob commented Apr 13, 2022

I can remove them here or look to alter the script depending on what you would like to do here.

This is correct 👍

examples/with-electron-typescript/package.json Outdated Show resolved Hide resolved
examples/with-electron/package.json Outdated Show resolved Hide resolved
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kodiakhq kodiakhq bot merged commit be3c804 into vercel:canary Apr 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants