Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize flakey prerender test #36193

Merged
merged 1 commit into from Apr 15, 2022
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 15, 2022

This fixes a race condition in a test where if we do a follow-up request fast enough the initial request could still be in the response-cache if writing the cache data to disk takes a bit.

x-ref: https://github.com/vercel/next.js/runs/6039605037?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/6039415211?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/6040144437?check_suite_focus=true

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Apr 15, 2022
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit 1c20d3d into vercel:canary Apr 15, 2022
@ijjk ijjk deleted the test/flakey-manual-revalidate branch April 15, 2022 16:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants