Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate streaming writer chunk type in testing #36200

Merged
merged 3 commits into from Apr 18, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 15, 2022

x-ref: #36165

Override streaming writer in testing to only allow the Uint8Array type of chunks being piped. Since we're using spwan to start the next process, so it cannot be hijacked in jest module mapper. Use require hook approach instead

Tested with code before #36165, it fails

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Apr 15, 2022
@ijjk
Copy link
Member

ijjk commented Apr 15, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary huozhi/next.js test/stream-write Change
buildDuration 15.6s 15.2s -387ms
buildDurationCached 6.2s 6s -135ms
nodeModulesSize 485 MB 485 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js test/stream-write Change
/ failed reqs 0 0
/ total time (seconds) 3.179 3.188 ⚠️ +0.01
/ avg req/sec 786.5 784.12 ⚠️ -2.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.359 1.401 ⚠️ +0.04
/error-in-render avg req/sec 1839.59 1784.21 ⚠️ -55.38
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js test/stream-write Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/stream-write Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/stream-write Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/stream-write Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/stream-write Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary huozhi/next.js test/stream-write Change
buildDuration 18.1s 18.3s ⚠️ +213ms
buildDurationCached 6s 6.1s ⚠️ +100ms
nodeModulesSize 485 MB 485 MB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js test/stream-write Change
/ failed reqs 0 0
/ total time (seconds) 3.184 3.214 ⚠️ +0.03
/ avg req/sec 785.07 777.8 ⚠️ -7.27
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.383 1.358 -0.02
/error-in-render avg req/sec 1807.37 1841.03 +33.66
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js test/stream-write Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/stream-write Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/stream-write Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/stream-write Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/stream-write Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: b42f42a

@huozhi huozhi marked this pull request as ready for review April 17, 2022 22:03
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is that we should revert back these overridden globale after each test, otherwise they can probably pollute other tests.

test/__mocks__/node-polyfill-web-streams.js Outdated Show resolved Hide resolved
@huozhi
Copy link
Member Author

huozhi commented Apr 18, 2022

@shuding the request hook only works per node process so the overriding will not work after the process is ended.

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@huozhi huozhi merged commit 2e00eb6 into vercel:canary Apr 18, 2022
@huozhi huozhi deleted the test/stream-write branch April 18, 2022 14:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants