Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI cache key to allow re-running only failed #36249

Merged
merged 1 commit into from Apr 18, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 18, 2022

Previously we made the cache key specific to each run attempt to allow having a separate cache in case a previous build cache was incorrect but now that actions allow re-running only failed it seems more beneficial to allow re-using the build cache for the re-run and for cases where the build cache is incorrect a bump commit can be done instead.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Apr 18, 2022
@ijjk ijjk marked this pull request as ready for review April 18, 2022 19:04
@ijjk
Copy link
Member Author

ijjk commented Apr 18, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
buildDuration 16.1s 15.9s -178ms
buildDurationCached 6.1s 6.2s ⚠️ +30ms
nodeModulesSize 485 MB 485 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
/ failed reqs 0 0
/ total time (seconds) 3.253 3.243 -0.01
/ avg req/sec 768.55 770.9 +2.35
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.411 1.364 -0.05
/error-in-render avg req/sec 1771.35 1833.06 +61.71
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
buildDuration 19s 18.8s -247ms
buildDurationCached 6.1s 6.2s ⚠️ +29ms
nodeModulesSize 485 MB 485 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
/ failed reqs 0 0
/ total time (seconds) 3.281 3.296 ⚠️ +0.01
/ avg req/sec 762.05 758.39 ⚠️ -3.66
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.402 1.41 ⚠️ +0.01
/error-in-render avg req/sec 1783.41 1773.54 ⚠️ -9.87
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js test/allow-re-run-failed Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: d7461dd

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 4a8a3d2 into vercel:canary Apr 18, 2022
@ijjk ijjk deleted the test/allow-re-run-failed branch April 18, 2022 19:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants