Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add yoga to examples #36253

Merged
merged 14 commits into from Apr 19, 2022
Merged

Conversation

mmartinsoliv
Copy link
Contributor

@mmartinsoliv mmartinsoliv commented Apr 18, 2022

Description

The Yoga design system follows design guidelines specification, we developed a React and React Native UI library that contains a set of high-quality components that defines our interfaces.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Apr 18, 2022
examples/with-yoga/README.md Outdated Show resolved Hide resolved
@mmartinsoliv mmartinsoliv requested a review from ijjk April 19, 2022 21:45
examples/with-yoga/pages/index.js Outdated Show resolved Hide resolved
examples/with-yoga/pages/index.js Outdated Show resolved Hide resolved
@mmartinsoliv mmartinsoliv requested a review from ijjk April 19, 2022 22:02
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit 91fd597 into vercel:canary Apr 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants