Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Typescript and Mantine example #36294

Merged
merged 23 commits into from Apr 27, 2022
Merged

Adding Typescript and Mantine example #36294

merged 23 commits into from Apr 27, 2022

Conversation

triyanox
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Apr 20, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added some comments.

I think we can just call the folder with-mantine and drop -typescript, as we plan to only add TS examples whenever possible, as mentioned in https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples

Editing the setup commands to match the new title 'with-mantine'
balazsorban44
balazsorban44 previously approved these changes Apr 25, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@triyanox
Copy link
Contributor Author

I have made some changes to pass all the test including the failing linting test due to code formatting !

@kodiakhq kodiakhq bot merged commit fca1071 into vercel:canary Apr 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants