Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the App and Component handling in render #36395

Merged
merged 3 commits into from Apr 22, 2022
Merged

Simplify the App and Component handling in render #36395

merged 3 commits into from Apr 22, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 22, 2022

Make the render procedure of App and Component more explict and clear

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 22, 2022
@ijjk
Copy link
Member

ijjk commented Apr 22, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js refactor/render Change
buildDuration 16.9s 16s -872ms
buildDurationCached 6.3s 6.4s ⚠️ +29ms
nodeModulesSize 481 MB 481 MB -626 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js refactor/render Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.398 3.402 0
/ avg req/sec 735.81 734.88 ⚠️ -0.93
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.474 1.513 ⚠️ +0.04
/error-in-render avg req/sec 1696.39 1652.17 ⚠️ -44.22
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js refactor/render Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28.6 kB 28.6 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.3 kB 72.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js refactor/render Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js refactor/render Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 3.04 kB 3.04 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.73 kB 5.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.36 kB 2.36 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js refactor/render Change
_buildManifest.js gzip 461 B 461 B ✓
Overall change 461 B 461 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js refactor/render Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓

Diffs

Diff for main-HASH.js 
@@ -3554,18 +3554,17 @@
                 {
                   style: styles.error
                 },
-                true &&
+                /*#__PURE__*/ _react.default.createElement(
+                  _head.default,
+                  null,
                   /*#__PURE__*/ _react.default.createElement(
-                    _head.default,
+                    "title",
                     null,
-                    /*#__PURE__*/ _react.default.createElement(
-                      "title",
-                      null,
-                      statusCode
-                        ? "".concat(statusCode, ": ").concat(title)
-                        : "Application error: a client-side exception has occurred"
-                    )
-                  ),
+                    statusCode
+                      ? "".concat(statusCode, ": ").concat(title)
+                      : "Application error: a client-side exception has occurred"
+                  )
+                ),
                 /*#__PURE__*/ _react.default.createElement(
                   "div",
                   null,
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-5850be3d57898234.js"
+      src="/_next/static/chunks/main-ae64527b37d6c65e.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-5850be3d57898234.js"
+      src="/_next/static/chunks/main-ae64527b37d6c65e.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-5850be3d57898234.js"
+      src="/_next/static/chunks/main-ae64527b37d6c65e.js"
       defer=""
     ></script>
     <script
Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js refactor/render Change
buildDuration 18.2s 18.6s ⚠️ +336ms
buildDurationCached 5.9s 5.8s -142ms
nodeModulesSize 481 MB 481 MB -626 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js refactor/render Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.247 3.289 ⚠️ +0.04
/ avg req/sec 769.99 760.21 ⚠️ -9.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.469 1.364 -0.1
/error-in-render avg req/sec 1701.56 1833.09 +131.53
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js refactor/render Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 29.1 kB 29.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.9 kB 72.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js refactor/render Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js refactor/render Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 325 B 325 B ✓
dynamic-HASH.js gzip 3.02 kB 3.02 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.78 kB 5.78 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.44 kB 2.44 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 393 B 393 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.1 kB 16.1 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js refactor/render Change
_buildManifest.js gzip 457 B 457 B ✓
Overall change 457 B 457 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js refactor/render Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓

Diffs

Diff for main-HASH.js 
@@ -3554,18 +3554,17 @@
                 {
                   style: styles.error
                 },
-                true &&
+                /*#__PURE__*/ _react.default.createElement(
+                  _head.default,
+                  null,
                   /*#__PURE__*/ _react.default.createElement(
-                    _head.default,
+                    "title",
                     null,
-                    /*#__PURE__*/ _react.default.createElement(
-                      "title",
-                      null,
-                      statusCode
-                        ? "".concat(statusCode, ": ").concat(title)
-                        : "Application error: a client-side exception has occurred"
-                    )
-                  ),
+                    statusCode
+                      ? "".concat(statusCode, ": ").concat(title)
+                      : "Application error: a client-side exception has occurred"
+                  )
+                ),
                 /*#__PURE__*/ _react.default.createElement(
                   "div",
                   null,
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-5850be3d57898234.js"
+      src="/_next/static/chunks/main-ae64527b37d6c65e.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-5850be3d57898234.js"
+      src="/_next/static/chunks/main-ae64527b37d6c65e.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-5850be3d57898234.js"
+      src="/_next/static/chunks/main-ae64527b37d6c65e.js"
       defer=""
     ></script>
     <script
Commit: 417b040

@huozhi huozhi marked this pull request as ready for review April 22, 2022 20:22
@huozhi huozhi requested a review from shuding April 22, 2022 20:37
@kodiakhq kodiakhq bot merged commit ec4f96c into vercel:canary Apr 22, 2022
@huozhi huozhi deleted the refactor/render branch April 22, 2022 21:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huozhi @ijjk @shuding