Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-next-app): fix pnpm create step #36398

Merged
merged 2 commits into from Apr 25, 2022
Merged

chore(create-next-app): fix pnpm create step #36398

merged 2 commits into from Apr 25, 2022

Conversation

zaida04
Copy link
Contributor

@zaida04 zaida04 commented Apr 23, 2022

Small copy-paste mistake with the readme of create-next-app on the steps for using PNPM to execute.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Apr 23, 2022
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ijjk
Copy link
Member

ijjk commented Apr 25, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary zaida04/next.js patch-1 Change
buildDuration 15.2s 15.2s -29ms
buildDurationCached 6s 6s -28ms
nodeModulesSize 481 MB 481 MB
Page Load Tests Overall increase ✓
vercel/next.js canary zaida04/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.043 3.037 -0.01
/ avg req/sec 821.62 823.3 +1.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.171 1.157 -0.01
/error-in-render avg req/sec 2134.99 2161.22 +26.23
Client Bundles (main, webpack)
vercel/next.js canary zaida04/next.js patch-1 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary zaida04/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary zaida04/next.js patch-1 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary zaida04/next.js patch-1 Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary zaida04/next.js patch-1 Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary zaida04/next.js patch-1 Change
buildDuration 17.4s 17.5s ⚠️ +36ms
buildDurationCached 6.1s 6.1s -31ms
nodeModulesSize 481 MB 481 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary zaida04/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.03 3.058 ⚠️ +0.03
/ avg req/sec 825.18 817.61 ⚠️ -7.57
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.162 1.18 ⚠️ +0.02
/error-in-render avg req/sec 2152.17 2119.01 ⚠️ -33.16
Client Bundles (main, webpack)
vercel/next.js canary zaida04/next.js patch-1 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary zaida04/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary zaida04/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary zaida04/next.js patch-1 Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary zaida04/next.js patch-1 Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 3576901

@kodiakhq kodiakhq bot merged commit 963549e into vercel:canary Apr 25, 2022
@zaida04 zaida04 deleted the patch-1 branch April 25, 2022 03:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants