Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change getStaticProps to getStaticPaths in getStaticPaths docs #36403

Merged
merged 1 commit into from Apr 23, 2022
Merged

Change getStaticProps to getStaticPaths in getStaticPaths docs #36403

merged 1 commit into from Apr 23, 2022

Conversation

youngvform
Copy link
Contributor

@youngvform youngvform commented Apr 23, 2022 •
edited

Overview

The subject is When does getStaticPaths run but this docs denotes about getStaticProps.
So could you check getStaticProps is right?

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@kodiakhq kodiakhq bot merged commit 2a42de2 into vercel:canary Apr 23, 2022
@stefanprobst
Copy link
Contributor

@leerob what does "getStaticPaths runs during next build for any paths returned [from getStaticPaths i guess] during build" mean?

@timneutkens
Copy link
Member

That's wrong indeed, will let the docs team know.

ijjk added a commit that referenced this pull request Apr 25, 2022
@ijjk
Revert "Change getStaticProps to getStaticPaths in getStaticPaths docs (
2208745 
#36403)"

This reverts commit 2a42de2.
@ijjk ijjk mentioned this pull request Apr 25, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Apr 25, 2022
@ijjk
Revert "Change getStaticProps to getStaticPaths in getStaticPaths doc…
e832007 
…s" (#36425)

This change was un-necessary and `getStaticProps` was correct here so this reverts the change. 

Reverts #36403
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@youngvform @stefanprobst @timneutkens @leerob @ijjk