Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing interpolation on next/head exports #36435

Merged
merged 1 commit into from Apr 26, 2022
Merged

Fix missing interpolation on next/head exports #36435

merged 1 commit into from Apr 26, 2022

Conversation

Brooooooklyn
Copy link
Contributor

fixes #36183

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Apr 26, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-head-interpolate Change
buildDuration 15.7s 15.7s -43ms
buildDurationCached 6.1s 6.2s ⚠️ +123ms
nodeModulesSize 481 MB 481 MB ⚠️ +58 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix-head-interpolate Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.203 3.231 ⚠️ +0.03
/ avg req/sec 780.48 773.75 ⚠️ -6.73
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.372 1.368 0
/error-in-render avg req/sec 1822.04 1827.98 +5.94
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-head-interpolate Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28.6 kB 28.6 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.3 kB 72.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-head-interpolate Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-head-interpolate Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 3.04 kB 3.04 kB ✓
head-HASH.js gzip 351 B 378 B ⚠️ +27 B
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.73 kB 5.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.63 kB 2.63 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.3 kB 16.3 kB ⚠️ +27 B
Client Build Manifests Overall decrease ✓
vercel/next.js canary vercel/next.js fix-head-interpolate Change
_buildManifest.js gzip 461 B 460 B -1 B
Overall change 461 B 460 B -1 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-head-interpolate Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓

Diffs

Diff for _buildManifest.js 
@@ -10,7 +10,7 @@ self.__BUILD_MANIFEST = {
   "/dynamic": [
     "static\u002Fchunks\u002Fpages\u002Fdynamic-2fc05fc466ebee90.js"
   ],
-  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-96a5d6ed07cf5a83.js"],
+  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-b3f5cd04a41e9ce4.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-9dfe734f583d4926.js"],
   "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-4ebd299a1253d245.js"],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-5b526b867abc83fc.js"],
Diff for head-HASH.js 
@@ -37,6 +37,9 @@
       /* harmony import */ var next_head__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(
         9008
       );
+      /* harmony import */ var next_head__WEBPACK_IMPORTED_MODULE_1___default = /*#__PURE__*/ __webpack_require__.n(
+        next_head__WEBPACK_IMPORTED_MODULE_1__
+      );
 
       var Page = function() {
         return /*#__PURE__*/ (0,
@@ -46,7 +49,7 @@
             children: [
               /*#__PURE__*/ (0,
               react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsx)(
-                next_head__WEBPACK_IMPORTED_MODULE_1__["default"],
+                next_head__WEBPACK_IMPORTED_MODULE_1___default(),
                 {
                   children: /*#__PURE__*/ (0,
                   react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsx)("title", {
@@ -73,7 +76,9 @@
       __unused_webpack_exports,
       __webpack_require__
     ) {
-      module.exports = __webpack_require__(3121);
+      var head = __webpack_require__(3121);
+      Object.assign(head.default, head);
+      module.exports = head.default;
 
       /***/
     }
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-head-interpolate Change
buildDuration 18s 18s -52ms
buildDurationCached 6.1s 6.1s ⚠️ +27ms
nodeModulesSize 481 MB 481 MB ⚠️ +58 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-head-interpolate Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.232 3.234 0
/ avg req/sec 773.44 773.07 ⚠️ -0.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.397 1.371 -0.03
/error-in-render avg req/sec 1789.2 1822.94 +33.74
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-head-interpolate Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 29.1 kB 29.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.9 kB 72.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-head-interpolate Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-head-interpolate Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 325 B 325 B ✓
dynamic-HASH.js gzip 3.02 kB 3.02 kB ✓
head-HASH.js gzip 351 B 385 B ⚠️ +34 B
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.78 kB 5.78 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.74 kB 2.74 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 393 B 393 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.4 kB 16.4 kB ⚠️ +34 B
Client Build Manifests Overall decrease ✓
vercel/next.js canary vercel/next.js fix-head-interpolate Change
_buildManifest.js gzip 457 B 456 B -1 B
Overall change 457 B 456 B -1 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-head-interpolate Change
index.html gzip 530 B 530 B ✓
link.html gzip 542 B 542 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓

Diffs

Diff for _buildManifest.js 
@@ -10,7 +10,7 @@ self.__BUILD_MANIFEST = {
   "/dynamic": [
     "static\u002Fchunks\u002Fpages\u002Fdynamic-2fc05fc466ebee90.js"
   ],
-  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-96a5d6ed07cf5a83.js"],
+  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-b3f5cd04a41e9ce4.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-9dfe734f583d4926.js"],
   "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-4ebd299a1253d245.js"],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-5b526b867abc83fc.js"],
Diff for head-HASH.js 
@@ -37,6 +37,9 @@
       /* harmony import */ var next_head__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(
         9008
       );
+      /* harmony import */ var next_head__WEBPACK_IMPORTED_MODULE_1___default = /*#__PURE__*/ __webpack_require__.n(
+        next_head__WEBPACK_IMPORTED_MODULE_1__
+      );
 
       var Page = function() {
         return /*#__PURE__*/ (0,
@@ -46,7 +49,7 @@
             children: [
               /*#__PURE__*/ (0,
               react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsx)(
-                next_head__WEBPACK_IMPORTED_MODULE_1__["default"],
+                next_head__WEBPACK_IMPORTED_MODULE_1___default(),
                 {
                   children: /*#__PURE__*/ (0,
                   react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsx)("title", {
@@ -73,7 +76,9 @@
       __unused_webpack_exports,
       __webpack_require__
     ) {
-      module.exports = __webpack_require__(3121);
+      var head = __webpack_require__(3121);
+      Object.assign(head.default, head);
+      module.exports = head.default;
 
       /***/
     }
Commit: fee601b

@kodiakhq kodiakhq bot merged commit 26efcc5 into canary Apr 26, 2022
@kodiakhq kodiakhq bot deleted the fix-head-interpolate branch April 26, 2022 04:13
@SukkaW
Copy link
Contributor

SukkaW commented Apr 26, 2022

It seems that packages/next/dynamic.js has the same issue.

SukkaW added a commit to SukkaW/next.js that referenced this pull request Apr 26, 2022
@SukkaW
fix(vercel#36435): apply correct fix
a5b966a
@SukkaW SukkaW mentioned this pull request Apr 26, 2022
Merged
3 tasks
ijjk pushed a commit that referenced this pull request Apr 26, 2022
@SukkaW
fix(#36435): apply correct fix (#36464)
487f7ab 
* fix(#36435): apply correct fix

* fix: only apply interop default flag for re-exported

I really, really love glob.

* test: add test cases for next/dynamic and next/amp
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[next/head] [ESM] Element type is invalid: expected a string
3 participants
@Brooooooklyn @ijjk @SukkaW