Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to remove webpack message per error #36452

Merged
merged 3 commits into from Apr 25, 2022

Conversation

nkzawa
Copy link
Contributor

@nkzawa nkzawa commented Apr 25, 2022

Remove the webpack breaking change message per error since it can be contained in all errors and the current implementation causes to truncate other error messages

Follow up for #36190

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk
Copy link
Member

ijjk commented Apr 25, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
buildDuration 16.2s 16.3s ⚠️ +67ms
buildDurationCached 6.3s 6.2s -46ms
nodeModulesSize 481 MB 481 MB ⚠️ +200 B
Page Load Tests Overall increase ✓
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
/ failed reqs 0 0
/ total time (seconds) 3.325 3.322 0
/ avg req/sec 751.93 752.64 +0.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.422 1.405 -0.02
/error-in-render avg req/sec 1758.01 1778.74 +20.73
Client Bundles (main, webpack)
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
buildDuration 18.2s 18.3s ⚠️ +100ms
buildDurationCached 6.3s 6.3s -39ms
nodeModulesSize 481 MB 481 MB ⚠️ +200 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
/ failed reqs 0 0
/ total time (seconds) 3.291 3.34 ⚠️ +0.05
/ avg req/sec 759.57 748.49 ⚠️ -11.08
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.399 1.448 ⚠️ +0.05
/error-in-render avg req/sec 1787.33 1726.91 ⚠️ -60.42
Client Bundles (main, webpack)
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary nkzawa/next.js fix-next-trim-webpack-message Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: c689555

@kodiakhq kodiakhq bot merged commit b264064 into vercel:canary Apr 25, 2022
@nkzawa nkzawa deleted the fix-next-trim-webpack-message branch April 26, 2022 07:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants