Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manual revalidate response cache handling #36462

Merged
merged 4 commits into from Apr 26, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 26, 2022

This updates to ensure we only resolve a manual revalidate request when the cache has been fully set instead of eagerly like we do for generating pages in fallback mode. This also ensures the response cache keys manual revalidate requests separate from normal requests to ensure one doesn't block the other. This should resolve the below flakey tests.

x-ref: https://github.com/vercel/next.js/runs/6163218261?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/6157328196?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/6151165153?check_suite_focus=true

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 26, 2022
@ijjk
Copy link
Member Author

ijjk commented Apr 26, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
buildDuration 15.1s 15.1s ⚠️ +2ms
buildDurationCached 6s 6.1s ⚠️ +33ms
nodeModulesSize 481 MB 481 MB ⚠️ +1.1 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
/ failed reqs 0 0
/ total time (seconds) 3.051 2.997 -0.05
/ avg req/sec 819.32 834.12 +14.8
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.169 1.169
/error-in-render avg req/sec 2138.58 2137.81 ⚠️ -0.77
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.63 kB 2.63 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
buildDuration 17.7s 17.5s -212ms
buildDurationCached 6.1s 6s -101ms
nodeModulesSize 481 MB 481 MB ⚠️ +1.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
/ failed reqs 0 0
/ total time (seconds) 3.022 3.06 ⚠️ +0.04
/ avg req/sec 827.15 817 ⚠️ -10.15
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.17 1.198 ⚠️ +0.03
/error-in-render avg req/sec 2136.83 2086.61 ⚠️ -50.22
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.74 kB 2.74 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.5 kB 16.5 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/manual-revalidate-response-cache Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 525 B
Overall change 1.59 kB 1.59 kB
Commit: d0654cd

@ijjk ijjk marked this pull request as ready for review April 26, 2022 02:32
@ijjk ijjk requested a review from styfle April 26, 2022 16:16
@kodiakhq kodiakhq bot merged commit e442569 into vercel:canary Apr 26, 2022
@ijjk ijjk deleted the update/manual-revalidate-response-cache branch April 26, 2022 19:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants