Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stitches and material-ui tests for new link behavior + fix TypeScript types when imported #36474

Merged
merged 5 commits into from Apr 26, 2022

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Apr 26, 2022

Adds additional tests for material-ui and stitches based on questions in the Twitter thread.

Fixes TypeScript types when LinkProps is imported and used in combination with <button>, added a TODO to change this at a later point when the new behavior is the default instead of opt-in.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Apr 26, 2022
@timneutkens timneutkens changed the title Add stitches and material-ui tests Add stitches and material-ui tests for new link behavior Apr 26, 2022
@ijjk

This comment was marked as outdated.

@ijjk
Copy link
Member

ijjk commented Apr 26, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
buildDuration 16.5s 16s -452ms
buildDurationCached 6.2s 6.4s ⚠️ +143ms
nodeModulesSize 481 MB 481 MB -5 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
/ failed reqs 0 0
/ total time (seconds) 3.247 3.258 ⚠️ +0.01
/ avg req/sec 769.86 767.42 ⚠️ -2.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.368 1.352 -0.02
/error-in-render avg req/sec 1827.13 1848.61 +21.48
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 378 B 378 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.63 kB 2.63 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
buildDuration 18.4s 18.5s ⚠️ +130ms
buildDurationCached 6.2s 6.2s -84ms
nodeModulesSize 481 MB 481 MB -5 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
/ failed reqs 0 0
/ total time (seconds) 3.278 3.29 ⚠️ +0.01
/ avg req/sec 762.68 759.82 ⚠️ -2.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.393 1.396 0
/error-in-render avg req/sec 1794.59 1791.28 ⚠️ -3.31
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 385 B 385 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.74 kB 2.74 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/more-link-tests Change
index.html gzip 530 B 530 B
link.html gzip 542 B 542 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: e35e4b7

@timneutkens timneutkens changed the title Add stitches and material-ui tests for new link behavior Add stitches and material-ui tests for new link behavior + fix TypeScript types when imported Apr 26, 2022
@kodiakhq kodiakhq bot merged commit 7d3bfac into vercel:canary Apr 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants