New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update swc #36477
Update swc #36477
Conversation
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
buildDuration | 19s | 19.2s | |
buildDurationCached | 7.7s | 7.6s | -85ms |
nodeModulesSize | 481 MB | 481 MB | ✓ |
Page Load Tests Overall increase ✓
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.879 | 3.876 | 0 |
/ avg req/sec | 644.47 | 644.94 | +0.47 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.637 | 1.631 | -0.01 |
/error-in-render avg req/sec | 1526.94 | 1533.18 | +6.24 |
Client Bundles (main, webpack)
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
925.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42 kB | 42 kB | ✓ |
main-HASH.js gzip | 28.6 kB | 28.6 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 72.3 kB | 72.3 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.36 kB | 1.36 kB | ✓ |
_error-HASH.js gzip | 192 B | 192 B | ✓ |
amp-HASH.js gzip | 309 B | 309 B | ✓ |
css-HASH.js gzip | 327 B | 327 B | ✓ |
dynamic-HASH.js gzip | 3.08 kB | 3.08 kB | ✓ |
head-HASH.js gzip | 357 B | 357 B | ✓ |
hooks-HASH.js gzip | 920 B | 920 B | ✓ |
image-HASH.js gzip | 5.73 kB | 5.73 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 2.63 kB | 2.63 kB | ✓ |
routerDirect..HASH.js gzip | 320 B | 320 B | ✓ |
script-HASH.js gzip | 392 B | 392 B | ✓ |
withRouter-HASH.js gzip | 319 B | 319 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 16.3 kB | 16.3 kB | ✓ |
Client Build Manifests
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
index.html gzip | 531 B | 531 B | ✓ |
link.html gzip | 545 B | 545 B | ✓ |
withRouter.html gzip | 526 B | 526 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Default Build with SWC (Increase detected ⚠️ )
General
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
buildDuration | 21.5s | 21s | -471ms |
buildDurationCached | 7.5s | 7.6s | |
nodeModulesSize | 481 MB | 481 MB | ✓ |
Page Load Tests Overall increase ✓
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.919 | 3.922 | 0 |
/ avg req/sec | 637.94 | 637.38 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.648 | 1.618 | -0.03 |
/error-in-render avg req/sec | 1517.19 | 1545.31 | +28.12 |
Client Bundles (main, webpack)
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
925.HASH.js gzip | 178 B | 178 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 29.1 kB | 29.1 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 72.9 kB | 72.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
_error-HASH.js gzip | 179 B | 179 B | ✓ |
amp-HASH.js gzip | 313 B | 313 B | ✓ |
css-HASH.js gzip | 325 B | 325 B | ✓ |
dynamic-HASH.js gzip | 3.08 kB | 3.08 kB | ✓ |
head-HASH.js gzip | 359 B | 359 B | ✓ |
hooks-HASH.js gzip | 921 B | 921 B | ✓ |
image-HASH.js gzip | 5.78 kB | 5.78 kB | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 2.74 kB | 2.74 kB | ✓ |
routerDirect..HASH.js gzip | 322 B | 322 B | ✓ |
script-HASH.js gzip | 393 B | 393 B | ✓ |
withRouter-HASH.js gzip | 317 B | 317 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 16.5 kB | 16.5 kB | ✓ |
Client Build Manifests
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
_buildManifest.js gzip | 458 B | 458 B | ✓ |
Overall change | 458 B | 458 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | kdy1/next.js swc-up-9 | Change | |
---|---|---|---|
index.html gzip | 530 B | 530 B | ✓ |
link.html gzip | 542 B | 542 B | ✓ |
withRouter.html gzip | 524 B | 524 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Hello @kdy1 . First of all I'm really impressed with what you're doing. Just a gentle ping about a regression probably linked to this commit, see the desc belgattitude/perso#9 Hope it's useful. |
@belgattitude Is it regression caused by this commit? |
Can't say for sure. It stopped working from 12.1.6-canary.9 and 12.1.6-canary.10. Your P/R was merged in https://github.com/vercel/next.js/releases/tag/v12.1.6-canary.10. Tested with Something that catches my eyes was the error about useLayoutEffect. So it's possibly linked to React 18.1.0 (I updated few days ago too). |
I investigated it and it's a bug of property inliner, so I disabled it with swc-project/swc#4468 |
That's fast 😄 |
This update swc to swc-project/swc@3428694
This PR includes several patch for the minifier bugs, and 5% ~ 13% performance improvement of the minifier