Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use edge compiler for middleware #36486

Merged
merged 7 commits into from Apr 27, 2022
Merged

Use edge compiler for middleware #36486

merged 7 commits into from Apr 27, 2022

Conversation

javivelasco
Copy link
Member

This PR:

  • Refactor path-match in order to make it easier to use to generate middleware configuration:
    • Removes one factory level in favour of parameters.
    • Makes parameters point free.
    • Exposes a named function.
    • Adds comments
  • Removes the unused functions-manifest-plugin
  • Makes middleware use the Edge compiler in preparation for upcoming middleware work.
    • Refactors how we handle compilers when getting the Webpack configuration to make it easier to understand.
    • Refactors how we create entrypoints for the compiler reusing a lot of logic and making things simpler.
    • Improves types for loaders and other functions.

@ijjk
Copy link
Member

ijjk commented Apr 26, 2022 •
edited

Failing test suites

Commit: 7c07c4f

yarn testheadless test/integration/production/test/index.test.js

  • Production Usage > should output traces
Expand output

● Production Usage › should output traces

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  281 |           return false
  282 |         })
> 283 |       ).toBe(true)
      |         ^
  284 |
  285 |       if (sep === '/') {
  286 |         expect(

  at Object.<anonymous> (integration/production/test/index.test.js:283:9)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Apr 26, 2022 •
edited

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
buildDuration 15.4s 15.6s ⚠️ +213ms
buildDurationCached 6.2s 5.9s -261ms
nodeModulesSize 481 MB 481 MB -18.3 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.254 3.224 -0.03
/ avg req/sec 768.26 775.43 +7.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.307 1.393 ⚠️ +0.09
/error-in-render avg req/sec 1912.46 1794.85 ⚠️ -117.61
Client Bundles (main, webpack)
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28.6 kB 28.6 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.3 kB 72.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
_app-HASH.js gzip 1.36 kB 1.36 kB ⚠️ +1 B
_error-HASH.js gzip 192 B 193 B ⚠️ +1 B
amp-HASH.js gzip 309 B 308 B -1 B
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 3.08 kB 3.08 kB ✓
head-HASH.js gzip 357 B 359 B ⚠️ +2 B
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.73 kB 5.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.63 kB 2.63 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 392 B 391 B -1 B
withRouter-HASH.js gzip 319 B 318 B -1 B
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.3 kB 16.3 kB ⚠️ +1 B
Client Build Manifests
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
index.html gzip 531 B 532 B ⚠️ +1 B
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ⚠️ +1 B

Diffs

Diff for _buildManifest.js 
@@ -1,25 +1,25 @@
 self.__BUILD_MANIFEST = {
   __rewrites: { beforeFiles: [], afterFiles: [], fallback: [] },
-  "/": ["static\u002Fchunks\u002Fpages\u002Findex-a49797fad5e5a39b.js"],
-  "/_error": ["static\u002Fchunks\u002Fpages\u002F_error-5d03de5a43fe90da.js"],
-  "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-c7cbac1df9ead194.js"],
+  "/": ["static\u002Fchunks\u002Fpages\u002Findex-7eff8c9e187d9f9d.js"],
+  "/_error": ["static\u002Fchunks\u002Fpages\u002F_error-f87d4319387a4b59.js"],
+  "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-56b55622017aff70.js"],
   "/css": [
     "static\u002Fcss\u002F94fdbc56eafa2039.css",
-    "static\u002Fchunks\u002Fpages\u002Fcss-f8d6ff68a6e8b080.js"
+    "static\u002Fchunks\u002Fpages\u002Fcss-436fa6bb26fc4120.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-7fda0a7b63c06ef1.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-80f5580e1c1b8ce3.js"
   ],
-  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-ae8daed8e1e5c446.js"],
-  "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-9dfe734f583d4926.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-4ebd299a1253d245.js"],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-5b526b867abc83fc.js"],
+  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-544bb68363445a0e.js"],
+  "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-c1372eeb4916d32c.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-bfb178f7d6259a9d.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-b2c86b9b6041c9a3.js"],
   "/routerDirect": [
-    "static\u002Fchunks\u002Fpages\u002FrouterDirect-98eb70bf22fb21da.js"
+    "static\u002Fchunks\u002Fpages\u002FrouterDirect-113a7082ae16fbcb.js"
   ],
-  "/script": ["static\u002Fchunks\u002Fpages\u002Fscript-1d699e963b4c9346.js"],
+  "/script": ["static\u002Fchunks\u002Fpages\u002Fscript-3ef13c748c65083c.js"],
   "/withRouter": [
-    "static\u002Fchunks\u002Fpages\u002FwithRouter-ee616b01250df021.js"
+    "static\u002Fchunks\u002Fpages\u002FwithRouter-04f6802cebd3d340.js"
   ],
   sortedPages: [
     "\u002F",
Diff for _app-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [888],
   {
-    /***/ 915: /***/ function(
+    /***/ 1597: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -282,7 +282,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 179], function() {
-      return __webpack_exec__(915), __webpack_exec__(880);
+      return __webpack_exec__(1597), __webpack_exec__(880);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for _error-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [820],
   {
-    /***/ 4977: /***/ function(
+    /***/ 1981: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -24,7 +24,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [888, 774, 179], function() {
-      return __webpack_exec__(4977);
+      return __webpack_exec__(1981);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for amp-HASH.js 
@@ -11,7 +11,7 @@
       /***/
     },
 
-    /***/ 6071: /***/ function(
+    /***/ 6005: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -69,7 +69,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [888, 774, 179], function() {
-      return __webpack_exec__(6071);
+      return __webpack_exec__(6005);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for css-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [706],
   {
-    /***/ 7083: /***/ function(
+    /***/ 6518: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -61,7 +61,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(7083);
+      return __webpack_exec__(6518);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for dynamic-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [739],
   {
-    /***/ 1893: /***/ function(
+    /***/ 4665: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -830,7 +830,7 @@ object-assign
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(1893);
+      return __webpack_exec__(4665);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for head-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [645],
   {
-    /***/ 4251: /***/ function(
+    /***/ 528: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -87,7 +87,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(4251);
+      return __webpack_exec__(528);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for hooks-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [757],
   {
-    /***/ 1470: /***/ function(
+    /***/ 8459: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -158,7 +158,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(1470);
+      return __webpack_exec__(8459);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for image-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [358],
   {
-    /***/ 2361: /***/ function(
+    /***/ 8700: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -1391,7 +1391,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(2361);
+      return __webpack_exec__(8700);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for index-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [405],
   {
-    /***/ 8581: /***/ function(
+    /***/ 5557: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -46,7 +46,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [888, 774, 179], function() {
-      return __webpack_exec__(8581);
+      return __webpack_exec__(5557);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for link-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [644],
   {
-    /***/ 7847: /***/ function(
+    /***/ 8129: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -686,7 +686,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(7847);
+      return __webpack_exec__(8129);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for routerDirect-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [58],
   {
-    /***/ 5448: /***/ function(
+    /***/ 4525: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -73,7 +73,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(5448);
+      return __webpack_exec__(4525);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for script-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [797],
   {
-    /***/ 5344: /***/ function(
+    /***/ 846: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -86,7 +86,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(5344);
+      return __webpack_exec__(846);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for withRouter-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [807],
   {
-    /***/ 6744: /***/ function(
+    /***/ 9704: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -70,7 +70,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(6744);
+      return __webpack_exec__(9704);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for index.html 
@@ -23,11 +23,11 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-71642a8ccc3189c6.js"
+      src="/_next/static/chunks/pages/_app-6bc74693935b0e21.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/index-a49797fad5e5a39b.js"
+      src="/_next/static/chunks/pages/index-7eff8c9e187d9f9d.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Diff for link.html 
@@ -23,11 +23,11 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-71642a8ccc3189c6.js"
+      src="/_next/static/chunks/pages/_app-6bc74693935b0e21.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-5b526b867abc83fc.js"
+      src="/_next/static/chunks/pages/link-b2c86b9b6041c9a3.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Diff for withRouter.html 
@@ -23,11 +23,11 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-71642a8ccc3189c6.js"
+      src="/_next/static/chunks/pages/_app-6bc74693935b0e21.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/withRouter-ee616b01250df021.js"
+      src="/_next/static/chunks/pages/withRouter-04f6802cebd3d340.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
buildDuration 17.3s 17.2s -60ms
buildDurationCached 5.8s 5.9s ⚠️ +23ms
nodeModulesSize 481 MB 481 MB -18.3 kB
Page Load Tests Overall increase ✓
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.236 3.187 -0.05
/ avg req/sec 772.58 784.37 +11.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.41 1.395 -0.01
/error-in-render avg req/sec 1773.25 1791.59 +18.34
Client Bundles (main, webpack)
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 29.1 kB 29.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.9 kB 72.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages Overall decrease ✓
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
_app-HASH.js gzip 1.35 kB 1.35 kB ⚠️ +1 B
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 312 B -1 B
css-HASH.js gzip 325 B 324 B -1 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB -1 B
head-HASH.js gzip 359 B 357 B -2 B
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.78 kB 5.78 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.74 kB 2.74 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 393 B 392 B -1 B
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.5 kB 16.4 kB -5 B
Client Build Manifests Overall decrease ✓
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
_buildManifest.js gzip 458 B 456 B -2 B
Overall change 458 B 456 B -2 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary javivelasco/next.js use-edge-compiler-for-middleware Change
index.html gzip 530 B 529 B -1 B
link.html gzip 542 B 543 B ⚠️ +1 B
withRouter.html gzip 524 B 526 B ⚠️ +2 B
Overall change 1.6 kB 1.6 kB ⚠️ +2 B

Diffs

Diff for _buildManifest.js 
@@ -1,25 +1,25 @@
 self.__BUILD_MANIFEST = {
   __rewrites: { beforeFiles: [], afterFiles: [], fallback: [] },
-  "/": ["static\u002Fchunks\u002Fpages\u002Findex-a49797fad5e5a39b.js"],
-  "/_error": ["static\u002Fchunks\u002Fpages\u002F_error-5d03de5a43fe90da.js"],
-  "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-c7cbac1df9ead194.js"],
+  "/": ["static\u002Fchunks\u002Fpages\u002Findex-7eff8c9e187d9f9d.js"],
+  "/_error": ["static\u002Fchunks\u002Fpages\u002F_error-f87d4319387a4b59.js"],
+  "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-56b55622017aff70.js"],
   "/css": [
     "static\u002Fcss\u002F94fdbc56eafa2039.css",
-    "static\u002Fchunks\u002Fpages\u002Fcss-f8d6ff68a6e8b080.js"
+    "static\u002Fchunks\u002Fpages\u002Fcss-436fa6bb26fc4120.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-7fda0a7b63c06ef1.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-80f5580e1c1b8ce3.js"
   ],
-  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-ae8daed8e1e5c446.js"],
-  "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-9dfe734f583d4926.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-4ebd299a1253d245.js"],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-5b526b867abc83fc.js"],
+  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-544bb68363445a0e.js"],
+  "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-c1372eeb4916d32c.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-bfb178f7d6259a9d.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-b2c86b9b6041c9a3.js"],
   "/routerDirect": [
-    "static\u002Fchunks\u002Fpages\u002FrouterDirect-98eb70bf22fb21da.js"
+    "static\u002Fchunks\u002Fpages\u002FrouterDirect-113a7082ae16fbcb.js"
   ],
-  "/script": ["static\u002Fchunks\u002Fpages\u002Fscript-1d699e963b4c9346.js"],
+  "/script": ["static\u002Fchunks\u002Fpages\u002Fscript-3ef13c748c65083c.js"],
   "/withRouter": [
-    "static\u002Fchunks\u002Fpages\u002FwithRouter-ee616b01250df021.js"
+    "static\u002Fchunks\u002Fpages\u002FwithRouter-04f6802cebd3d340.js"
   ],
   sortedPages: [
     "\u002F",
Diff for _app-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [888],
   {
-    /***/ 915: /***/ function(
+    /***/ 1597: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -282,7 +282,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 179], function() {
-      return __webpack_exec__(915), __webpack_exec__(880);
+      return __webpack_exec__(1597), __webpack_exec__(880);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for _error-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [820],
   {
-    /***/ 4977: /***/ function(
+    /***/ 1981: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -24,7 +24,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [888, 774, 179], function() {
-      return __webpack_exec__(4977);
+      return __webpack_exec__(1981);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for amp-HASH.js 
@@ -11,7 +11,7 @@
       /***/
     },
 
-    /***/ 6071: /***/ function(
+    /***/ 6005: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -69,7 +69,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [888, 774, 179], function() {
-      return __webpack_exec__(6071);
+      return __webpack_exec__(6005);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for css-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [706],
   {
-    /***/ 7083: /***/ function(
+    /***/ 6518: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -61,7 +61,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(7083);
+      return __webpack_exec__(6518);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for dynamic-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [739],
   {
-    /***/ 1893: /***/ function(
+    /***/ 4665: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -830,7 +830,7 @@ object-assign
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(1893);
+      return __webpack_exec__(4665);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for head-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [645],
   {
-    /***/ 4251: /***/ function(
+    /***/ 528: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -87,7 +87,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(4251);
+      return __webpack_exec__(528);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for hooks-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [757],
   {
-    /***/ 1470: /***/ function(
+    /***/ 8459: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -158,7 +158,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(1470);
+      return __webpack_exec__(8459);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for image-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [358],
   {
-    /***/ 2361: /***/ function(
+    /***/ 8700: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -1391,7 +1391,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(2361);
+      return __webpack_exec__(8700);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for index-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [405],
   {
-    /***/ 8581: /***/ function(
+    /***/ 5557: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -46,7 +46,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [888, 774, 179], function() {
-      return __webpack_exec__(8581);
+      return __webpack_exec__(5557);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for link-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [644],
   {
-    /***/ 7847: /***/ function(
+    /***/ 8129: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -686,7 +686,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(7847);
+      return __webpack_exec__(8129);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for routerDirect-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [58],
   {
-    /***/ 5448: /***/ function(
+    /***/ 4525: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -73,7 +73,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(5448);
+      return __webpack_exec__(4525);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for script-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [797],
   {
-    /***/ 5344: /***/ function(
+    /***/ 846: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -86,7 +86,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(5344);
+      return __webpack_exec__(846);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for withRouter-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [807],
   {
-    /***/ 6744: /***/ function(
+    /***/ 9704: /***/ function(
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -70,7 +70,7 @@
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
     /******/ __webpack_require__.O(0, [774, 888, 179], function() {
-      return __webpack_exec__(6744);
+      return __webpack_exec__(9704);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for index.html 
@@ -23,11 +23,11 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-71642a8ccc3189c6.js"
+      src="/_next/static/chunks/pages/_app-6bc74693935b0e21.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/index-a49797fad5e5a39b.js"
+      src="/_next/static/chunks/pages/index-7eff8c9e187d9f9d.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Diff for link.html 
@@ -23,11 +23,11 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-71642a8ccc3189c6.js"
+      src="/_next/static/chunks/pages/_app-6bc74693935b0e21.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-5b526b867abc83fc.js"
+      src="/_next/static/chunks/pages/link-b2c86b9b6041c9a3.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Diff for withRouter.html 
@@ -23,11 +23,11 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-71642a8ccc3189c6.js"
+      src="/_next/static/chunks/pages/_app-6bc74693935b0e21.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/withRouter-ee616b01250df021.js"
+      src="/_next/static/chunks/pages/withRouter-04f6802cebd3d340.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Commit: 5001417

@javivelasco javivelasco force-pushed the use-edge-compiler-for-middleware branch 2 times, most recently from 7c07c4f to cb7fbf9 Compare April 26, 2022 22:30
@javivelasco javivelasco force-pushed the use-edge-compiler-for-middleware branch from e9b35a1 to 47516fc Compare April 27, 2022 07:59
javivelasco and others added 2 commits April 27, 2022 10:20
@javivelasco
Use Edge Compiler for Middleware & Refactor
581c7bc
@javivelasco @ijjk
Update some comments
5001417 
Co-authored-by: JJ Kasper <jj@jjsweb.site>

Update packages/next/shared/lib/router/utils/path-match.ts

Co-authored-by: JJ Kasper <jj@jjsweb.site>

Update packages/next/shared/lib/router/utils/path-match.ts

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@javivelasco javivelasco force-pushed the use-edge-compiler-for-middleware branch from 47516fc to 5001417 Compare April 27, 2022 08:20
huozhi
huozhi reviewed Apr 27, 2022
View reviewed changes
Copy link
Member

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuding shuding merged commit 0bf6655 into vercel:canary Apr 27, 2022
@javivelasco javivelasco deleted the use-edge-compiler-for-middleware branch April 27, 2022 10:02
@balazsorban44 balazsorban44 mentioned this pull request May 10, 2022
Closed
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi left review comments

@ijjk ijjk ijjk left review comments

@shuding shuding shuding approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@javivelasco @ijjk @shuding @huozhi