Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react dev dep to 18.1 #36491

Merged
merged 6 commits into from Apr 28, 2022
Merged

Bump react dev dep to 18.1 #36491

merged 6 commits into from Apr 28, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 26, 2022

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Apr 26, 2022
@ijjk
Copy link
Member

ijjk commented Apr 26, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary huozhi/next.js react-18-1 Change
buildDuration 16s 15.9s -152ms
buildDurationCached 6.2s 6.2s ⚠️ +2ms
nodeModulesSize 481 MB 481 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js react-18-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.298 3.28 -0.02
/ avg req/sec 758.05 762.19 +4.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.37 1.408 ⚠️ +0.04
/error-in-render avg req/sec 1824.58 1775.85 ⚠️ -48.73
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js react-18-1 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js react-18-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js react-18-1 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.63 kB 2.63 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js react-18-1 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js react-18-1 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary huozhi/next.js react-18-1 Change
buildDuration 18s 17.9s -127ms
buildDurationCached 6.3s 6.1s -128ms
nodeModulesSize 481 MB 481 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js react-18-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.274 3.273 0
/ avg req/sec 763.49 763.76 +0.27
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.363 1.386 ⚠️ +0.02
/error-in-render avg req/sec 1834.61 1803.12 ⚠️ -31.49
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js react-18-1 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js react-18-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js react-18-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.74 kB 2.74 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js react-18-1 Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js react-18-1 Change
index.html gzip 528 B 528 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: b50a9ca

@huozhi huozhi marked this pull request as ready for review April 26, 2022 22:54
@balazsorban44
Copy link
Member

Anything to do about #35746 (comment) related to this?

@huozhi
Copy link
Member Author

huozhi commented Apr 27, 2022

@balazsorban44 We could update it later, it will might effect the case that when using dynamic() API without suspense: true option with react 18.
And with react 18, you can just switch to React.lazy even in SSR mode which is supported natively

@ijjk
Copy link
Member

ijjk commented Apr 27, 2022

Failing test suites

Commit: b50a9ca

yarn testheadless test/e2e/yarn-pnp/test/with-styled-components-babel.test.ts

  • yarn PnP > should compile and serve the index page correctly with-styled-components-babel
Expand output

● yarn PnP › should compile and serve the index page correctly with-styled-components-babel

thrown: "Exceeded timeout of 120000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  21 |     let next: NextInstance
  22 |
> 23 |     beforeAll(async () => {
     |     ^
  24 |       const srcDir = join(__dirname, '../../../../examples', example)
  25 |       const srcFiles = await fs.readdir(srcDir)
  26 |

  at Object.runTests (e2e/yarn-pnp/test/utils.ts:23:5)
  at e2e/yarn-pnp/test/with-styled-components-babel.test.ts:4:43
  at Object.<anonymous> (e2e/yarn-pnp/test/with-styled-components-babel.test.ts:3:1)

Read more about building and testing Next.js in contributing.md.

@timneutkens timneutkens merged commit ea81df0 into vercel:canary Apr 28, 2022
@huozhi huozhi deleted the react-18-1 branch April 28, 2022 10:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants