Remove passhref Eslint rule as it's no longer needed with new link behavior

[timneutkens]

Found this while upgrading the vercel.com app.

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

Documentation / Examples

• Make sure the linting passes by running yarn lint

[ijjk]

Failing test suites

Commit: 5e734fc

yarn testheadless test/e2e/yarn-pnp/test/with-styled-components-babel.test.ts

• yarn PnP > should compile and serve the index page correctly with-styled-components-babel

Expand output

● yarn PnP › should compile and serve the index page correctly with-styled-components-babel

FetchError: request to http://localhost:46429/ failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1491:11)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
buildDuration	15.4s	15.3s	-149ms
buildDurationCached	6.1s	6s	-99ms
nodeModulesSize	481 MB	481 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.064	3.111	⚠️ +0.05
/ avg req/sec	815.84	803.57	⚠️ -12.27
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.217	1.211	-0.01
/error-in-render avg req/sec	2054.32	2064.98	+10.66

Client Bundles (main, webpack)

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28.6 kB	28.6 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.3 kB	72.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	308 B	308 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	3.08 kB	3.08 kB	✓
head-HASH.js gzip	359 B	359 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.73 kB	5.73 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.63 kB	2.63 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	391 B	391 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.3 kB	16.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Default Build with SWC (Decrease detected ✓)

General

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
buildDuration	17.4s	17.5s	⚠️ +31ms
buildDurationCached	6.1s	6.1s	⚠️ +31ms
nodeModulesSize	481 MB	481 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.014	3.666	⚠️ +0.65
/ avg req/sec	829.58	681.93	⚠️ -147.65
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.169	1.301	⚠️ +0.13
/error-in-render avg req/sec	2138.94	1920.92	⚠️ -218.02

Client Bundles (main, webpack)

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	29.1 kB	29.1 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.9 kB	72.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	3.08 kB	3.08 kB	✓
head-HASH.js gzip	357 B	357 B	✓
hooks-HASH.js gzip	921 B	921 B	✓
image-HASH.js gzip	5.78 kB	5.78 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.74 kB	2.74 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	392 B	392 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.4 kB	16.4 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
_buildManifest.js gzip	456 B	456 B	✓
Overall change	456 B	456 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/remove-passhref-rule	Change
index.html gzip	529 B	529 B	✓
link.html gzip	543 B	543 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 5e734fc