Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure optional params are normalized correctly in minimal mode #36513

Merged
merged 6 commits into from Apr 27, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 27, 2022

Follow-up for #36463 this fixes an issue with optional catch-all params not being normalized correctly which was caught by the runtimes tests.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 27, 2022
@ijjk
Copy link
Member Author

ijjk commented Apr 27, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
buildDuration 20.4s 21s ⚠️ +585ms
buildDurationCached 7.6s 7.8s ⚠️ +202ms
nodeModulesSize 481 MB 481 MB ⚠️ +21 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
/ failed reqs 0 0
/ total time (seconds) 4.536 4.632 ⚠️ +0.1
/ avg req/sec 551.17 539.78 ⚠️ -11.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.187 2.218 ⚠️ +0.03
/error-in-render avg req/sec 1143.1 1127.24 ⚠️ -15.86
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.63 kB 2.63 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
buildDuration 23.1s 22.7s -336ms
buildDurationCached 7.7s 7.8s ⚠️ +35ms
nodeModulesSize 481 MB 481 MB ⚠️ +21 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
/ failed reqs 0 0
/ total time (seconds) 4.453 4.466 ⚠️ +0.01
/ avg req/sec 561.45 559.83 ⚠️ -1.62
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.21 2.22 ⚠️ +0.01
/error-in-render avg req/sec 1131.37 1126.11 ⚠️ -5.26
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.74 kB 2.74 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/optional-revalidate-params Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 2dc9351

@ijjk ijjk marked this pull request as ready for review April 27, 2022 15:36
@kodiakhq kodiakhq bot merged commit d66445f into vercel:canary Apr 27, 2022
@ijjk ijjk deleted the fix/optional-revalidate-params branch April 27, 2022 18:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants