Add string children case for newNextLinkBehavior codemod

[timneutkens]

Found this while running the codemod on the vercel.com app, it ended up adding oldBehavior to links with string content only.

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

Documentation / Examples

• Make sure the linting passes by running yarn lint

[ijjk]

Failing test suites

Commit: e34a9fb

yarn testheadless test/e2e/yarn-pnp/test/with-styled-components-babel.test.ts

• yarn PnP > should compile and serve the index page correctly with-styled-components-babel

Expand output

● yarn PnP › should compile and serve the index page correctly with-styled-components-babel

thrown: "Exceeded timeout of 120000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  21 |     let next: NextInstance
  22 |
> 23 |     beforeAll(async () => {
     |     ^
  24 |       const srcDir = join(__dirname, '../../../../examples', example)
  25 |       const srcFiles = await fs.readdir(srcDir)
  26 |

  at Object.runTests (e2e/yarn-pnp/test/utils.ts:23:5)
  at e2e/yarn-pnp/test/with-styled-components-babel.test.ts:4:43
  at Object.<anonymous> (e2e/yarn-pnp/test/with-styled-components-babel.test.ts:3:1)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
buildDuration	15.5s	15.6s	⚠️ +58ms
buildDurationCached	6.1s	6s	-78ms
nodeModulesSize	481 MB	481 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.086	3.096	⚠️ +0.01
/ avg req/sec	810.16	807.38	⚠️ -2.78
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.199	1.21	⚠️ +0.01
/error-in-render avg req/sec	2084.85	2066.74	⚠️ -18.11

Client Bundles (main, webpack)

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28.6 kB	28.6 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.3 kB	72.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	308 B	308 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	3.08 kB	3.08 kB	✓
head-HASH.js gzip	359 B	359 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.73 kB	5.73 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.63 kB	2.63 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	391 B	391 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.3 kB	16.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Default Build with SWC (Increase detected ⚠️)

General

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
buildDuration	17.7s	17.7s	⚠️ +27ms
buildDurationCached	6.1s	6.2s	⚠️ +64ms
nodeModulesSize	481 MB	481 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.087	3.093	⚠️ +0.01
/ avg req/sec	809.72	808.29	⚠️ -1.43
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.225	1.22	-0.01
/error-in-render avg req/sec	2041.05	2049.37	+8.32

Client Bundles (main, webpack)

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	29.1 kB	29.1 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.9 kB	72.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	3.08 kB	3.08 kB	✓
head-HASH.js gzip	357 B	357 B	✓
hooks-HASH.js gzip	921 B	921 B	✓
image-HASH.js gzip	5.78 kB	5.78 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.74 kB	2.74 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	392 B	392 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.4 kB	16.4 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
_buildManifest.js gzip	456 B	456 B	✓
Overall change	456 B	456 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/string-children-link-codemod	Change
index.html gzip	528 B	528 B	✓
link.html gzip	543 B	543 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: e34a9fb