Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra yarn PnP example test #36518

Merged
merged 1 commit into from Apr 27, 2022
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 27, 2022

Since this test seems to be failing here and there and we already have a TypeScript PnP test this removes this specific fixture

x-ref: https://github.com/vercel/next.js/runs/6197090560?check_suite_focus=true
x-ref: #36516 (comment)

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Apr 27, 2022
@ijjk
Copy link
Member Author

ijjk commented Apr 27, 2022

Failing test suites

Commit: 8c3b62a

yarn testheadless test/integration/custom-routes/test/index.test.js

  • Custom routes > serverless mode > should handle external beforeFiles rewrite correctly
Expand output

● Custom routes › serverless mode › should handle external beforeFiles rewrite correctly

expect(received).toBe(expected) // Object.is equality

Expected: 200
Received: 500

  89 |       console.error('Invalid response', html)
  90 |     }
> 91 |     expect(res.status).toBe(200)
     |                        ^
  92 |     expect(html).toContain('Vercel')
  93 |
  94 |     const browser = await webdriver(appPort, '/nav')

  at Object.<anonymous> (integration/custom-routes/test/index.test.js:91:24)

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk merged commit 89a4c16 into vercel:canary Apr 27, 2022
@ijjk ijjk deleted the rm/flakey-pnp-test branch April 27, 2022 16:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant