Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish isomorphic path module #36521

Merged
merged 5 commits into from Apr 27, 2022
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 27, 2022

List all exports for internal path module to avoid import destruction is breaking with typescript.

Prev

import pathMod from '../isomorphic/path'

const { join, resolve } = pathMod

Now

import { join, resolve } from '../isomorphic/path'

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 27, 2022
@ijjk

This comment was marked as outdated.

@huozhi huozhi marked this pull request as ready for review April 27, 2022 17:59
@ijjk
Copy link
Member

ijjk commented Apr 27, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
buildDuration 15.7s 15.8s ⚠️ +84ms
buildDurationCached 6.2s 6.1s -101ms
nodeModulesSize 481 MB 481 MB -363 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
/ failed reqs 0 0
/ total time (seconds) 3.1 3.163 ⚠️ +0.06
/ avg req/sec 806.5 790.37 ⚠️ -16.13
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.201 1.223 ⚠️ +0.02
/error-in-render avg req/sec 2080.85 2044.85 ⚠️ -36
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.63 kB 2.63 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
buildDuration 17.9s 18.5s ⚠️ +598ms
buildDurationCached 6.2s 6.2s ⚠️ +36ms
nodeModulesSize 481 MB 481 MB -363 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
/ failed reqs 0 0
/ total time (seconds) 3.174 3.598 ⚠️ +0.42
/ avg req/sec 787.65 694.84 ⚠️ -92.81
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.215 1.362 ⚠️ +0.15
/error-in-render avg req/sec 2057.93 1836.15 ⚠️ -221.78
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.74 kB 2.74 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js polish-iso-path-module Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: edb767e

@kodiakhq kodiakhq bot merged commit e9b423b into vercel:canary Apr 27, 2022
@huozhi huozhi deleted the polish-iso-path-module branch April 27, 2022 18:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants