Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next-swc/wasm: Make span start at 0 #36532

Merged
merged 1 commit into from Apr 28, 2022
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 28, 2022

This is follow-up of #36482

@ijjk
Copy link
Member

ijjk commented Apr 28, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary kdy1/next.js parser-span Change
buildDuration 18s 18.7s ⚠️ +747ms
buildDurationCached 7s 7.1s ⚠️ +109ms
nodeModulesSize 481 MB 481 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js parser-span Change
/ failed reqs 0 0
/ total time (seconds) 4.045 4.035 -0.01
/ avg req/sec 618.05 619.58 +1.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.007 1.938 -0.07
/error-in-render avg req/sec 1245.76 1289.69 +43.93
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js parser-span Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js parser-span Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js parser-span Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.63 kB 2.63 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js parser-span Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js parser-span Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary kdy1/next.js parser-span Change
buildDuration 20.6s 20.7s ⚠️ +57ms
buildDurationCached 7s 7s ⚠️ +22ms
nodeModulesSize 481 MB 481 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js parser-span Change
/ failed reqs 0 0
/ total time (seconds) 4.057 4.041 -0.02
/ avg req/sec 616.23 618.73 +2.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.003 1.952 -0.05
/error-in-render avg req/sec 1247.96 1280.79 +32.83
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js parser-span Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js parser-span Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js parser-span Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.76 kB 5.76 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.74 kB 2.74 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js parser-span Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js parser-span Change
index.html gzip 527 B 527 B
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 525 B
Overall change 1.59 kB 1.59 kB
Commit: f67470d

@timneutkens timneutkens merged commit 3aa8aaa into vercel:canary Apr 28, 2022
@timneutkens timneutkens deleted the parser-span branch April 28, 2022 09:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants