Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc #36535

Merged
merged 9 commits into from Apr 28, 2022
Merged

Update swc #36535

merged 9 commits into from Apr 28, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 28, 2022

This PR updates swc to swc-project/swc@a72f436

This PR applies

@ijjk
Copy link
Member

ijjk commented Apr 28, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary kdy1/next.js swc-up-10 Change
buildDuration 16.3s 16.4s ⚠️ +156ms
buildDurationCached 6.5s 6.2s -296ms
nodeModulesSize 463 MB 463 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-up-10 Change
/ failed reqs 0 0
/ total time (seconds) 3.291 3.27 -0.02
/ avg req/sec 759.56 764.42 +4.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.413 1.365 -0.05
/error-in-render avg req/sec 1769.71 1831.17 +61.46
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-up-10 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-10 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-10 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-10 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-10 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-up-10 Change
buildDuration 18.4s 18.1s -236ms
buildDurationCached 6.2s 6.2s ⚠️ +17ms
nodeModulesSize 463 MB 463 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-10 Change
/ failed reqs 0 0
/ total time (seconds) 3.27 3.325 ⚠️ +0.06
/ avg req/sec 764.53 751.98 ⚠️ -12.55
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.387 1.425 ⚠️ +0.04
/error-in-render avg req/sec 1802.79 1754.29 ⚠️ -48.5
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-up-10 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-10 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-10 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.76 kB 5.76 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.5 kB 16.5 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-10 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-10 Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 3bba1b6

@kdy1 kdy1 marked this pull request as draft April 28, 2022 07:58
@kdy1
Copy link
Member Author

kdy1 commented Apr 28, 2022

I'll undraft this after including swc-project/swc#4468

The swc PR is for recent version of react, which is now compressed with google closure compiler

@kdy1 kdy1 marked this pull request as ready for review April 28, 2022 08:38
@kodiakhq kodiakhq bot merged commit 38aa6d7 into vercel:canary Apr 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants