Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak lockfile patching to be eager #36549

Merged
merged 5 commits into from Apr 28, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 28, 2022

This is a follow-up to #36527 to make sure we eagerly patch the lockfile as the correct swc dependency will be present if the platform matches so the load failure isn't hit which is where we were previously patching the lockfile. This is done in the background so does not block compilation. This also removes some extra logs that aren't necessary.

before lockfile patch

before

after lockfile patch

after

This also fixes a case I noticed where we weren't flushing events before exiting when builds fail

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 28, 2022
@ijjk ijjk marked this pull request as ready for review April 28, 2022 15:09
@ijjk
Copy link
Member Author

ijjk commented Apr 28, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
buildDuration 19.4s 19.6s ⚠️ +245ms
buildDurationCached 7.5s 7.6s ⚠️ +100ms
nodeModulesSize 463 MB 463 MB ⚠️ +7.19 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
/ failed reqs 0 0
/ total time (seconds) 4.071 3.904 -0.17
/ avg req/sec 614.13 640.34 +26.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.782 1.712 -0.07
/error-in-render avg req/sec 1403.28 1460.47 +57.19
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
buildDuration 21.7s 21.8s ⚠️ +136ms
buildDurationCached 7.5s 7.6s ⚠️ +106ms
nodeModulesSize 463 MB 463 MB ⚠️ +7.19 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
/ failed reqs 0 0
/ total time (seconds) 4.096 3.991 -0.1
/ avg req/sec 610.36 626.47 +16.11
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.735 1.712 -0.02
/error-in-render avg req/sec 1440.56 1460.45 +19.89
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.76 kB 5.76 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.5 kB 16.5 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/lockfile-patching Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 80c34f6

@kodiakhq kodiakhq bot merged commit 60f7423 into vercel:canary Apr 28, 2022
@ijjk ijjk deleted the update/lockfile-patching branch April 28, 2022 16:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants