Hoist the desired ReactDOM import expression

[huozhi]

• hoist react-dom/server imports to reduce module load time in nodejs
• simplify reactRoot detection condition by checking the streaming rendering API we're using. (if it doesn't existed, like react 17, then we won't enable reactRoot)
• Merge __NEXT_CONCURRENT_FEATURES into __NEXT_REACT_ROOT env var since they're identical now

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	huozhi/next.js opt-render	Change
buildDuration	16.5s	16.5s	-51ms
buildDurationCached	6.3s	6.5s	⚠️ +134ms
nodeModulesSize	463 MB	463 MB	-844 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	huozhi/next.js opt-render	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.38	3.86	⚠️ +0.48
/ avg req/sec	739.54	647.72	⚠️ -91.82
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.433	1.468	⚠️ +0.03
/error-in-render avg req/sec	1744.52	1702.42	⚠️ -42.1

Client Bundles (main, webpack)

	vercel/next.js canary	huozhi/next.js opt-render	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28.6 kB	28.6 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.3 kB	72.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	huozhi/next.js opt-render	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	huozhi/next.js opt-render	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	308 B	308 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	3.08 kB	3.08 kB	✓
head-HASH.js gzip	359 B	359 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.71 kB	5.71 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.64 kB	2.64 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	391 B	391 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.3 kB	16.3 kB	✓

Client Build Manifests

	vercel/next.js canary	huozhi/next.js opt-render	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	huozhi/next.js opt-render	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Default Build with SWC (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	huozhi/next.js opt-render	Change
buildDuration	18.6s	18.4s	-178ms
buildDurationCached	6.3s	6.4s	⚠️ +122ms
nodeModulesSize	463 MB	463 MB	-844 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	huozhi/next.js opt-render	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.363	3.803	⚠️ +0.44
/ avg req/sec	743.47	657.36	⚠️ -86.11
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.469	1.456	-0.01
/error-in-render avg req/sec	1702.4	1717.2	+14.8

Client Bundles (main, webpack)

	vercel/next.js canary	huozhi/next.js opt-render	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	29.1 kB	29.1 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.9 kB	72.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	huozhi/next.js opt-render	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	huozhi/next.js opt-render	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	3.08 kB	3.08 kB	✓
head-HASH.js gzip	357 B	357 B	✓
hooks-HASH.js gzip	921 B	921 B	✓
image-HASH.js gzip	5.76 kB	5.76 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.76 kB	2.76 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	392 B	392 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.5 kB	16.5 kB	✓

Client Build Manifests

	vercel/next.js canary	huozhi/next.js opt-render	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	huozhi/next.js opt-render	Change
index.html gzip	529 B	529 B	✓
link.html gzip	543 B	543 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 7ea373c

[adhirajsinghchauhan]

Note: this change causes Error: Cannot find module 'react-dom/server.browser.js' when using @preact/compat, since it doesn't provide server.*.js files.

I had to manually patch L76 in node_modules/next/dist/bin/next to be:

// Detect if react-dom is enabled streaming rendering mode
-const shouldUseReactRoot = !!require('react-dom/server.browser').renderToReadableStream;
+const shouldUseReactRoot = false;
// Version is inlined into the file using taskr build pipeline

[huozhi]

@adhirajsinghchauhan I filed #36749 to tweak some changes on next.js side as short term workaround but ideally preact needs to support /server.(node|browser) in long term exports which is already exported in react 17. Any library could import from react-dom/server.node or react-dom/server.browser.