Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump styled-jsx to latest #36554

Merged
merged 2 commits into from Apr 28, 2022
Merged

bump styled-jsx to latest #36554

merged 2 commits into from Apr 28, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 28, 2022

x-ref: coryetzkorn/twitter-algorithm#2

  • Bump styled-jsx to latest version (5.0.2), so that it could get dedup when user installs the styled-jsx manually
  • Remove the legacy @types/styled-jsx

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 28, 2022
@huozhi huozhi marked this pull request as ready for review April 28, 2022 18:04
@ijjk
Copy link
Member

ijjk commented Apr 28, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
buildDuration 15.6s 15.5s -47ms
buildDurationCached 6.3s 6.3s -28ms
nodeModulesSize 463 MB 463 MB ⚠️ +565 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
/ failed reqs 0 0
/ total time (seconds) 3.669 3.632 -0.04
/ avg req/sec 681.33 688.32 +6.99
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.392 1.354 -0.04
/error-in-render avg req/sec 1795.93 1846.51 +50.58
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
buildDuration 17.6s 17.4s -222ms
buildDurationCached 6.2s 6.2s ⚠️ +18ms
nodeModulesSize 463 MB 463 MB ⚠️ +565 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
/ failed reqs 0 0
/ total time (seconds) 3.674 3.678 0
/ avg req/sec 680.54 679.63 ⚠️ -0.91
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.354 1.366 ⚠️ +0.01
/error-in-render avg req/sec 1847 1830.72 ⚠️ -16.28
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.76 kB 5.76 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.5 kB 16.5 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js bump-styled-jsx Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 623ecd6

@kodiakhq kodiakhq bot merged commit ea779c5 into vercel:canary Apr 28, 2022
@huozhi huozhi deleted the bump-styled-jsx branch April 28, 2022 22:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants