Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure older lockfile/invalid formats are handled #36577

Merged
merged 1 commit into from Apr 29, 2022
Merged

Ensure older lockfile/invalid formats are handled #36577

merged 1 commit into from Apr 29, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 29, 2022

This ensures we gracefully handle lockfiles generated with npm v6 or older that don't have the packages field or when the content is invalid.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 29, 2022
@ijjk ijjk requested a review from balazsorban44 April 29, 2022 14:26
@ijjk ijjk merged commit e30d723 into vercel:canary Apr 29, 2022
@ijjk ijjk deleted the fix/handle-older-lockfile branch April 29, 2022 14:42
@NOUIY NOUIY mentioned this pull request May 23, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @balazsorban44