Update status code for normalize error #36580

ijjk · 2022-04-29T18:55:07Z

This updates to show a 400 (bad request) when an invalid path is sent to Next.js similar to our decode failure handling.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Closes: #36555

ijjk · 2022-04-29T19:18:51Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
buildDuration	15.3s	15.2s	-110ms
buildDurationCached	6.1s	6.1s	-66ms
nodeModulesSize	463 MB	463 MB	⚠️ +562 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.564	3.506	-0.06
/ avg req/sec	701.49	713.11	+11.62
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.191	1.16	-0.03
/error-in-render avg req/sec	2098.52	2156.07	+57.55

Client Bundles (main, webpack) Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28.6 kB	28.7 kB	⚠️ +24 B
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.3 kB	72.3 kB	⚠️ +24 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	308 B	308 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	3.08 kB	3.08 kB	✓
head-HASH.js gzip	359 B	359 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.71 kB	5.71 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.64 kB	2.64 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	391 B	391 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.3 kB	16.3 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
index.html gzip	533 B	533 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	529 B	529 B	✓
Overall change	1.61 kB	1.61 kB	✓

Diffs

Diff for main-HASH.js

@@ -8449,7 +8449,17 @@
         }
         return DecodeError;
       })(_wrapNativeSuper(Error));
-      exports.DecodeError = DecodeError; //# sourceMappingURL=utils.js.map
+      exports.DecodeError = DecodeError;
+      var NormalizeError = /*#__PURE__*/ (function(Error) {
+        _inherits(NormalizeError, Error);
+        var _super = _createSuper(NormalizeError);
+        function NormalizeError() {
+          _classCallCheck(this, NormalizeError);
+          return _super.apply(this, arguments);
+        }
+        return NormalizeError;
+      })(_wrapNativeSuper(Error));
+      exports.NormalizeError = NormalizeError; //# sourceMappingURL=utils.js.map
 
       /***/
     },

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-69b0414e03e5e1c2.js"
+      src="/_next/static/chunks/main-cda1cca10e3fcc7f.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-69b0414e03e5e1c2.js"
+      src="/_next/static/chunks/main-cda1cca10e3fcc7f.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-69b0414e03e5e1c2.js"
+      src="/_next/static/chunks/main-cda1cca10e3fcc7f.js"
       defer=""
     ></script>
     <script

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
buildDuration	17s	17.2s	⚠️ +144ms
buildDurationCached	6.1s	6.1s	⚠️ +15ms
nodeModulesSize	463 MB	463 MB	⚠️ +562 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.541	3.52	-0.02
/ avg req/sec	705.97	710.24	+4.27
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.161	1.178	⚠️ +0.02
/error-in-render avg req/sec	2153.47	2122.62	⚠️ -30.85

Client Bundles (main, webpack) Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	29 kB	29.1 kB	⚠️ +45 B
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.9 kB	73 kB	⚠️ +45 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	3.08 kB	3.08 kB	✓
head-HASH.js gzip	357 B	357 B	✓
hooks-HASH.js gzip	921 B	921 B	✓
image-HASH.js gzip	5.76 kB	5.76 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.76 kB	2.76 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	392 B	392 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.5 kB	16.5 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	ijjk/next.js update/normalize-error-status	Change
index.html gzip	528 B	527 B	-1 B
link.html gzip	541 B	541 B	✓
withRouter.html gzip	525 B	524 B	-1 B
Overall change	1.59 kB	1.59 kB	-2 B

Diffs

Diff for main-HASH.js

@@ -8449,7 +8449,17 @@
         }
         return DecodeError;
       })(_wrapNativeSuper(Error));
-      exports.DecodeError = DecodeError; //# sourceMappingURL=utils.js.map
+      exports.DecodeError = DecodeError;
+      var NormalizeError = /*#__PURE__*/ (function(Error) {
+        _inherits(NormalizeError, Error);
+        var _super = _createSuper(NormalizeError);
+        function NormalizeError() {
+          _classCallCheck(this, NormalizeError);
+          return _super.apply(this, arguments);
+        }
+        return NormalizeError;
+      })(_wrapNativeSuper(Error));
+      exports.NormalizeError = NormalizeError; //# sourceMappingURL=utils.js.map
 
       /***/
     },

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-69b0414e03e5e1c2.js"
+      src="/_next/static/chunks/main-cda1cca10e3fcc7f.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-69b0414e03e5e1c2.js"
+      src="/_next/static/chunks/main-cda1cca10e3fcc7f.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-69b0414e03e5e1c2.js"
+      src="/_next/static/chunks/main-cda1cca10e3fcc7f.js"
       defer=""
     ></script>
     <script

Commit: 3a5ab1e

ijjk · 2022-04-29T19:42:34Z

Failing test suites

Commit: 7ee89df

yarn testheadless test/e2e/prerender.test.ts

Prerender > should handle manual revalidate for fallback: blocking

Expand output

● Prerender › should handle manual revalidate for fallback: blocking

expect(received).toMatch(expected)

Expected pattern: /(HIT|STALE)/
Received string:  "MISS"

  2072 |         const $2 = cheerio.load(html2)
  2073 |
> 2074 |         expect(res2.headers.get('x-nextjs-cache')).toMatch(/(HIT|STALE)/)
       |                                                    ^
  2075 |         expect(initialTime).toBe($2('#time').text())
  2076 |
  2077 |         const res3 = await fetchViaHTTP(

  at Object.<anonymous> (e2e/prerender.test.ts:2074:52)

Read more about building and testing Next.js in contributing.md.

…ize-error-status

Update status code for normalize error

6ceae6c

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 29, 2022

fix lint

7ee89df

ijjk marked this pull request as ready for review April 29, 2022 19:26

ijjk requested review from timneutkens, shuding and huozhi as code owners April 29, 2022 19:26

timneutkens previously approved these changes May 1, 2022

View reviewed changes

timneutkens added 2 commits May 1, 2022 10:57

Merge branch 'canary' of github.com:vercel/next.js into update/normal…

7784d9c

…ize-error-status

Solve merge conflict

3a5ab1e

timneutkens dismissed their stale review via 3a5ab1e May 1, 2022 09:00

timneutkens approved these changes May 1, 2022

View reviewed changes

kodiakhq bot merged commit bd3dfe1 into vercel:canary May 1, 2022

NOUIY mentioned this pull request May 23, 2022

[Snyk] Upgrade next from 12.0.7 to 12.1.6 NOUIY/next.js#293

Open

github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update status code for normalize error #36580

Update status code for normalize error #36580

ijjk commented Apr 29, 2022

ijjk commented Apr 29, 2022 •

edited

Diffs

Diffs

ijjk commented Apr 29, 2022

Update status code for normalize error #36580

Update status code for normalize error #36580

Conversation

ijjk commented Apr 29, 2022

Bug

ijjk commented Apr 29, 2022 • edited

Stats from current PR

Diffs

Diffs

ijjk commented Apr 29, 2022

Failing test suites

ijjk commented Apr 29, 2022 •

edited