Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #36592

Merged
merged 1 commit into from Apr 30, 2022
Merged

Fix typo #36592

merged 1 commit into from Apr 30, 2022

Conversation

ro11ingbutler
Copy link
Contributor

@ro11ingbutler ro11ingbutler commented Apr 30, 2022 •
edited

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Apr 30, 2022
ijjk
ijjk approved these changes Apr 30, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 948128a into vercel:canary Apr 30, 2022
calbearox
calbearox reviewed Apr 30, 2022
View reviewed changes
Copy link

@calbearox calbearox left a comment •
edited by balazsorban44

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REDACTED

@ro11ingbutler ro11ingbutler deleted the patch-1 branch April 30, 2022 19:12
@NOUIY NOUIY mentioned this pull request May 23, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@calbearox calbearox calbearox left review comments

@leerob leerob leerob approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ro11ingbutler @leerob @ijjk @calbearox