Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagesDir to Jest transformer #36599

Merged
merged 6 commits into from May 1, 2022
Merged

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented May 1, 2022

Fixes #35469

Adds pagesDir which is required for the Relay transform.

Added a test case based on https://github.com/hanford/relay-swc-jest.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Fixes vercel#35469

Adds `pagesDir` which is required for the Relay transform.

I'll add a test case for it based on https://github.com/hanford/relay-swc-jest in a follow-up commit.

Co-Authored-By: Wonu Lee <wonwoolee24@gmail.com>
@ijjk
Copy link
Member

ijjk commented May 1, 2022

Failing test suites

Commit: 43766c0

yarn testheadless test/production/jest/relay/app/tests/entry.test.tsx

Expand output

● Test suite failed to run

Cannot find module 'react-relay' from 'production/jest/relay/app/tests/entry.test.tsx'

  1 | import { render as renderFn, waitFor } from '@testing-library/react'
> 2 | import { RelayEnvironmentProvider } from 'react-relay'
    |                                                       ^
  3 | import { createMockEnvironment, MockPayloadGenerator } from 'relay-test-utils'
  4 |
  5 | import Page from '../pages'

  at Resolver.resolveModule (../node_modules/jest-resolve/build/resolver.js:311:11)
  at Object.<anonymous> (production/jest/relay/app/tests/entry.test.tsx:2:55)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented May 1, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/35469 Change
buildDuration 15.9s 16.1s ⚠️ +102ms
buildDurationCached 6.2s 6.2s ⚠️ +31ms
nodeModulesSize 463 MB 463 MB ⚠️ +468 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/35469 Change
/ failed reqs 0 0
/ total time (seconds) 3.732 3.775 ⚠️ +0.04
/ avg req/sec 669.86 662.21 ⚠️ -7.65
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.378 1.389 ⚠️ +0.01
/error-in-render avg req/sec 1813.87 1799.82 ⚠️ -14.05
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js fix/35469 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/35469 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/35469 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.71 kB 5.71 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/35469 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/35469 Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/35469 Change
buildDuration 17.8s 17.8s -43ms
buildDurationCached 6.3s 6.2s -144ms
nodeModulesSize 463 MB 463 MB ⚠️ +468 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/35469 Change
/ failed reqs 0 0
/ total time (seconds) 3.748 3.774 ⚠️ +0.03
/ avg req/sec 666.98 662.49 ⚠️ -4.49
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.423 1.362 -0.06
/error-in-render avg req/sec 1756.27 1835.73 +79.46
Client Bundles (main, webpack)
vercel/next.js canary timneutkens/next.js fix/35469 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/35469 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/35469 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.08 kB 3.08 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.76 kB 5.76 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.5 kB 16.5 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/35469 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/35469 Change
index.html gzip 527 B 527 B
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 524 B
Overall change 1.59 kB 1.59 kB
Commit: bb8c457

@timneutkens timneutkens marked this pull request as ready for review May 1, 2022 12:45
ijjk
ijjk previously approved these changes May 1, 2022
ijjk
ijjk previously approved these changes May 1, 2022
@kodiakhq kodiakhq bot merged commit 5aa54b3 into vercel:canary May 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js 12.1 SWC + Relay + Jest not transpiling graphql tags
2 participants