Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues with environment variables for Windows users #37853

Merged
merged 2 commits into from Aug 11, 2022
Merged

Fixed issues with environment variables for Windows users #37853

merged 2 commits into from Aug 11, 2022

Conversation

alvinometric
Copy link
Contributor

@alvinometric alvinometric commented Jun 20, 2022 •
edited

Hello,

Just updating the Vercel + Contentful example because some windows users reported issues. This fixes them 馃檹

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jun 20, 2022
@alvinometric alvinometric marked this pull request as ready for review August 11, 2022 16:21
ijjk
ijjk approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit 1f6bc34 into vercel:canary Aug 11, 2022
@alvinometric alvinometric deleted the fix-contentful-env-vars branch August 11, 2022 16:40
@snyk-bot snyk-bot mentioned this pull request Sep 2, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alvinometric @ijjk