Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): updated react-multi-carousel to TS #37930

Merged
merged 9 commits into from Oct 1, 2022

Conversation

falsepopsky
Copy link
Contributor

Example

  • Moved to typescript
  • Making use of the Image API (old example only use image tag)

Dependencies

  • updated deps to latest
  • removed unused deps, just to focus on the current example and not other ones
@material-ui/core, @material-ui/icons, jss, mobile-detect, react-jss

Deploy

Example deploy

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jun 22, 2022
balazsorban44
balazsorban44 previously approved these changes Jun 23, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@falsepopsky falsepopsky changed the title [Examples] updated react-multi-carousel feat(Examples) updated react-multi-carousel Jul 2, 2022
@falsepopsky
Copy link
Contributor Author

falsepopsky commented Jul 5, 2022

@balazsorban44 sorry to ping, but kodiakhq never detected the approved changes

@balazsorban44 balazsorban44 self-requested a review July 6, 2022 12:53
balazsorban44
balazsorban44 previously approved these changes Jul 6, 2022
@falsepopsky falsepopsky changed the title feat(Examples) updated react-multi-carousel chore(example): updated react-multi-carousel to TS Jul 24, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balazsorban44 balazsorban44 merged commit e0c3d28 into vercel:canary Oct 1, 2022
BowlingX pushed a commit to BowlingX/next.js that referenced this pull request Oct 5, 2022
### Example

- Moved to typescript
- Making use of the Image API (old example only use image tag)

### Dependencies

- updated deps to latest
- removed unused deps, just to focus on the current example and not
other ones
```
@material-ui/core, @material-ui/icons, jss, mobile-detect, react-jss
```

 ### Deploy 

[Example deploy](https://rmcexample-86mr9qpaa-falsepopsky.vercel.app/)

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The examples guidelines are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

Co-authored-by: Balázs Orbán <info@balazsorban.com>
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
### Example

- Moved to typescript
- Making use of the Image API (old example only use image tag)

### Dependencies

- updated deps to latest
- removed unused deps, just to focus on the current example and not
other ones
```
@material-ui/core, @material-ui/icons, jss, mobile-detect, react-jss
```

 ### Deploy 

[Example deploy](https://rmcexample-86mr9qpaa-falsepopsky.vercel.app/)

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The examples guidelines are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

Co-authored-by: Balázs Orbán <info@balazsorban.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
@falsepopsky falsepopsky deleted the example-rmcarousel branch April 27, 2023 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants