-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): Convert api-routes
example to TypeScript
#38083
chore(examples): Convert api-routes
example to TypeScript
#38083
Conversation
api-routes
example to TypeScript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's consider #38091 (comment) on this and all future PRs!
Thanks @balazsorban44 - I made your requested change. I thought |
@balazsorban44 Thanks! Made your requested change, and ready for re-review! Can I also get confirmation that you recommend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
As for #38083 (comment), I think, for consistency's sake, we should use function
over const/let
uniformly, yes. default
exports might not be necessary though (unless a page or API route), because a file could export multiple things, but these are stylistic details and a grey area what we should enforce vs. prefer.
So (in my opinion) use function
whenever possible, but at the minimum for API Routes and pages. Rest should be at least consistent throughout the example. 👍
Opened #38511 to discuss the above and add it to the contributing guidelines |
Converted API Routes example over to TypeScript to match the Contribution guidelines.
Documentation / Examples
pnpm lint