Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NextUI example #38209

Merged
merged 56 commits into from Sep 29, 2022
Merged

Add NextUI example #38209

merged 56 commits into from Sep 29, 2022

Conversation

valcosmos
Copy link
Contributor

@valcosmos valcosmos commented Jun 30, 2022 •
edited

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jun 30, 2022
EliseiNicolae
EliseiNicolae previously approved these changes Jul 1, 2022
View reviewed changes
balazsorban44
balazsorban44 requested changes Jul 6, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please have a read of https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples

@balazsorban44
Copy link
Member

When running locally, I'm seeing the following warnings. Could we address these before merging?

image

@valcosmos
Copy link
Contributor Author

valcosmos commented Jul 11, 2022 •
edited

When running locally, I'm seeing the following warnings. Could we address these before merging?

@balazsorban44
Hello, I looked at the warning and I found that it was from NextUI itself, so I temporarily removed the component that was causing the warning. You can re-run and there should be no more warnings, or errors.

balazsorban44
balazsorban44 requested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add next-env.d.ts to .gitignore

examples/with-next-ui/.gitignore Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 8422f23 into vercel:canary Sep 29, 2022
BowlingX pushed a commit to BowlingX/next.js that referenced this pull request Oct 5, 2022
@valcosmos @balazsorban44 @BowlingX
Add NextUI example (vercel#38209)
511152e 
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@EliseiNicolae EliseiNicolae EliseiNicolae left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@valcosmos @balazsorban44 @EliseiNicolae @ijjk