adding with-axiom example #38300
Merged
adding with-axiom example #38300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schehata
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
balazsorban44
as code owners
balazsorban44
requested changes
Jul 6, 2022
There was a problem hiding this comment.
Let's convert to TypeScript. See: https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples
I have updated the PR now to be in TS, but pnpm is not working for me, it fails with GYP error. can we let it run through the CI? |
balazsorban44
requested changes
Jul 8, 2022
Co-authored-by: Balázs Orbán <info@balazsorban.com>
added. (thanks for the tip, saved my time :D) |
|
@balazsorban44 is there something that needs to be updated? |
steven-tey
previously approved these changes
Aug 30, 2022
balazsorban44
previously approved these changes
Sep 1, 2022
schehata
dismissed stale reviews from balazsorban44 and steven-tey
via
37b51f1
balazsorban44
approved these changes
Sep 1, 2022
atilafassina
pushed a commit
to atilafassina/next.js
that referenced
this pull request
Sep 5, 2022
## Documentation / Examples - [ X ] Make sure the linting passes by running `pnpm lint` - [ X ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) This PR adds an example for using next.js with axiom. Co-authored-by: Balázs Orbán <info@balazsorban.com> Co-authored-by: Steven Tey <stevensteel97@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation / Examples
pnpm lintThis PR adds an example for using next.js with axiom.